From: Greg KH <greg@kroah.com>
To: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: stable@vger.kernel.org, linux-rdma@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: [PATCH] IB/{hfi1,qib}: Add limit test for RC/UC send via loopback
Date: Mon, 11 Feb 2019 14:42:54 +0100 [thread overview]
Message-ID: <20190211134254.GF17709@kroah.com> (raw)
In-Reply-To: <20190204153639.2555.41856.stgit@scvm10.sc.intel.com>
On Mon, Feb 04, 2019 at 07:36:42AM -0800, Mike Marciniszyn wrote:
> Upstream commit 09ce351dff8e7636af0beb72cd4a86c3904a0500.
>
> Fix potential memory corruption and panic in loopback for
> IB_WR_SEND varaiants.
>
> The code blindly assumes the posted length will fit in the
> fetched rwqe, which is not a valid assumption.
>
> Fix by adding a limit test, and triggering the appropriate
> send completion and putting the QP in an error state. This
> mimics the handling for non-loopback QPs.
>
> [ported to older kernels where the loopback was in each driver]
>
> Cc: <stable@vger.kernel.org> #v4.9+
> Fixes: 7724105686e7 ("IB/hfi1: add driver files")
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> ---
> drivers/infiniband/hw/hfi1/ruc.c | 7 ++++++-
> drivers/infiniband/hw/qib/qib_ruc.c | 7 ++++++-
> 2 files changed, 12 insertions(+), 2 deletions(-)
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2019-02-11 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 15:36 [PATCH] IB/{hfi1,qib}: Add limit test for RC/UC send via loopback Mike Marciniszyn
2019-02-04 15:44 ` Greg KH
2019-02-04 16:25 ` Marciniszyn, Mike
2019-02-11 13:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211134254.GF17709@kroah.com \
--to=greg@kroah.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).