From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD5BC169C4 for ; Mon, 11 Feb 2019 13:42:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D0372229E for ; Mon, 11 Feb 2019 13:42:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="ebWmE+ZC"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="YhsAN8wr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727587AbfBKNm6 (ORCPT ); Mon, 11 Feb 2019 08:42:58 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:44333 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727223AbfBKNm6 (ORCPT ); Mon, 11 Feb 2019 08:42:58 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 58785220D3; Mon, 11 Feb 2019 08:42:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 11 Feb 2019 08:42:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=+TO/4ykaahRYvmNB102y6/lWAgL zC/pvXB/AjI7HZGU=; b=ebWmE+ZC4O3Qn4ZkFFsqNYfl05DSCJnT3uCkgD5M7tN obNWGdrTVS920coQ9UnTVWzVf4w3/bK1MHJJwpx0DJPVWcscXJyFMm5HqP9Iip25 yPxSgk864TkwmcVSQGK5L0/orrQmMFtL/2E8dxbN43XJCZCCCGC5OF8pWrV3MPsI pw0hGPZnoJIbKqUj9O40CqsaswMuY1G/HAmKMmcgZpxo+TeobSNY4IqQpV10b++N i4Bplp7pSx3AA8CoEEV8vymWXtRJnetNa0hlEWENICYQWQ3tVv5AleUVHq/1EM0U qXlg7IemBUu776wm3Y++PeN3gSrnEeUD++JQ65WBtsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+TO/4y kaahRYvmNB102y6/lWAgLzC/pvXB/AjI7HZGU=; b=YhsAN8wruYCkUh+UF7B5vb XtbWHljuHGz1QzD1KQazPtEmisDSypZ5aU99RHcf6McOKff7E/ZXppXE0VqzzWPN Q5rh+Yabd/noEVcCuD3Ywruzq9Mc5lM2MnmY4MLZW0dzrffalE+SCq6ta5/Z5Q9i GBVvvfM/N6VWnRQUMPrYs8t5hsIblKVTO5VK0YaKAlI+02vG0KX5psEeSrahg8Uw 8bTZs7EaLw+V5dJEjIs5GjzKuai6/FyLDuGn2TVxZKg7yGNanirNYDPbTAKqfGii iRi6VCgtMT+WMNJsvwbsmKXWAxScuhRloGaiAoMyjg2PasG2naKwgtZ1pmkLnc9Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrleelgdefkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgg gtuggjfgesthdtredttdervdenucfhrhhomhepifhrvghgucfmjfcuoehgrhgvgheskhhr ohgrhhdrtghomheqnecukfhppeekfedrkeeirdekledruddtjeenucfrrghrrghmpehmrg hilhhfrhhomhepghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgep td X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 4602AE436D; Mon, 11 Feb 2019 08:42:56 -0500 (EST) Date: Mon, 11 Feb 2019 14:42:54 +0100 From: Greg KH To: Mike Marciniszyn Cc: stable@vger.kernel.org, linux-rdma@vger.kernel.org, stable-commits@vger.kernel.org Subject: Re: [PATCH] IB/{hfi1,qib}: Add limit test for RC/UC send via loopback Message-ID: <20190211134254.GF17709@kroah.com> References: <20190204153639.2555.41856.stgit@scvm10.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190204153639.2555.41856.stgit@scvm10.sc.intel.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Feb 04, 2019 at 07:36:42AM -0800, Mike Marciniszyn wrote: > Upstream commit 09ce351dff8e7636af0beb72cd4a86c3904a0500. > > Fix potential memory corruption and panic in loopback for > IB_WR_SEND varaiants. > > The code blindly assumes the posted length will fit in the > fetched rwqe, which is not a valid assumption. > > Fix by adding a limit test, and triggering the appropriate > send completion and putting the QP in an error state. This > mimics the handling for non-loopback QPs. > > [ported to older kernels where the loopback was in each driver] > > Cc: #v4.9+ > Fixes: 7724105686e7 ("IB/hfi1: add driver files") > Reviewed-by: Michael J. Ruhl > Signed-off-by: Mike Marciniszyn > --- > drivers/infiniband/hw/hfi1/ruc.c | 7 ++++++- > drivers/infiniband/hw/qib/qib_ruc.c | 7 ++++++- > 2 files changed, 12 insertions(+), 2 deletions(-) Now queued up, thanks. greg k-h