From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 7/8] hisi_sas: fix calls to dma_set_mask_and_coherent()
Date: Mon, 18 Feb 2019 10:26:27 +0100 [thread overview]
Message-ID: <20190218092627.GG5241@lst.de> (raw)
In-Reply-To: <20190218073426.111853-8-hare@suse.de>
On Mon, Feb 18, 2019 at 08:34:25AM +0100, Hannes Reinecke wrote:
> The change to use dma_set_mask_and_coherent() incorrectly made a second
> call with the 32 bit DMA mask value when the call with the 64 bit DMA
> mask value succeeded. This resulted in FC connections failing due
> to corrupted data buffers, and various other SCSI/FCP I/O errors.
Looks good (modulo the FCP copy and paste noticed by John):
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-02-18 9:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190218073426.111853-1-hare@suse.de>
2019-02-18 7:34 ` [PATCH 1/8] lpfc: fix calls to dma_set_mask_and_coherent() Hannes Reinecke
2019-02-18 9:24 ` Christoph Hellwig
2019-02-26 0:29 ` Ewan Milne
2019-02-18 7:34 ` [PATCH 2/8] 3w-9xxx: " Hannes Reinecke
2019-02-18 9:24 ` Christoph Hellwig
2019-02-26 0:30 ` Ewan Milne
2019-02-18 7:34 ` [PATCH 3/8] 3w-sas: " Hannes Reinecke
2019-02-18 9:24 ` Christoph Hellwig
2019-02-26 0:30 ` Ewan Milne
2019-02-18 7:34 ` [PATCH 4/8] " Hannes Reinecke
2019-02-18 9:25 ` Christoph Hellwig
2019-02-26 0:32 ` Ewan Milne
2019-02-18 7:34 ` [PATCH 5/8] bfa: " Hannes Reinecke
2019-02-18 9:25 ` Christoph Hellwig
2019-02-26 0:34 ` Ewan Milne
2019-02-18 7:34 ` [PATCH 6/8] csiostor: " Hannes Reinecke
2019-02-18 9:25 ` Christoph Hellwig
2019-02-26 0:35 ` Ewan Milne
2019-02-18 7:34 ` [PATCH 7/8] hisi_sas: " Hannes Reinecke
2019-02-18 9:24 ` John Garry
2019-02-18 9:26 ` Christoph Hellwig [this message]
2019-02-26 0:37 ` Ewan Milne
2019-02-18 7:34 ` [PATCH 8/8] hptiop: fix calls to dma_set_mask() Hannes Reinecke
2019-02-18 9:26 ` Christoph Hellwig
2019-02-26 0:38 ` Ewan Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218092627.GG5241@lst.de \
--to=hch@lst.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).