From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FCB7C10F02 for ; Mon, 18 Feb 2019 09:26:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0598920838 for ; Mon, 18 Feb 2019 09:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729019AbfBRJ03 (ORCPT ); Mon, 18 Feb 2019 04:26:29 -0500 Received: from verein.lst.de ([213.95.11.211]:43801 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728447AbfBRJ03 (ORCPT ); Mon, 18 Feb 2019 04:26:29 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id E11F268D93; Mon, 18 Feb 2019 10:26:27 +0100 (CET) Date: Mon, 18 Feb 2019 10:26:27 +0100 From: Christoph Hellwig To: Hannes Reinecke Cc: "Martin K. Petersen" , Christoph Hellwig , James Bottomley , linux-scsi@vger.kernel.org, stable@vger.kernel.org, Hannes Reinecke Subject: Re: [PATCH 7/8] hisi_sas: fix calls to dma_set_mask_and_coherent() Message-ID: <20190218092627.GG5241@lst.de> References: <20190218073426.111853-1-hare@suse.de> <20190218073426.111853-8-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190218073426.111853-8-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Feb 18, 2019 at 08:34:25AM +0100, Hannes Reinecke wrote: > The change to use dma_set_mask_and_coherent() incorrectly made a second > call with the 32 bit DMA mask value when the call with the 64 bit DMA > mask value succeeded. This resulted in FC connections failing due > to corrupted data buffers, and various other SCSI/FCP I/O errors. Looks good (modulo the FCP copy and paste noticed by John): Reviewed-by: Christoph Hellwig