From: Greg KH <greg@kroah.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
Chris Redpath <Chris.Redpath@arm.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
nd <nd@arm.com>,
"pkondeti@codeaurora.org" <pkondeti@codeaurora.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
Todd Kjos <tkjos@android.com>
Subject: Re: 4.14 stable missing 3054426dc68e "sched, trace: Fix prev_state output in sched_switch tracepoint"
Date: Mon, 18 Feb 2019 13:19:12 +0100 [thread overview]
Message-ID: <20190218121912.GA30260@kroah.com> (raw)
In-Reply-To: <20190218091403.jgy6zi7klrijk6oq@debian>
On Mon, Feb 18, 2019 at 09:14:03AM +0000, Sudip Mukherjee wrote:
> Hi Sasha,
>
> On Sun, Feb 17, 2019 at 09:06:36PM -0500, Sasha Levin wrote:
> > On Fri, Feb 15, 2019 at 12:26:35PM +0000, Chris Redpath wrote:
> > > Hi Greg et al.
> > >
> > > A user of android-4.14 has pointed the following missing commit out.
> > >
> > > Commit 3054426dc68e ("sched, trace: Fix prev_state output in sched_switch tracepoint") was put into linux-4.20 around rc5 to fix an issue in a tracepoint. According to the patch itself, the broken commit was 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout") which was merged at what looks like 4.15-rc2. The broken commit was also picked for 4.14.64 as 13f12749af15 ("sched/debug: Fix task state recording/printout"). The fix (3054426dc68e) was pulled into 4.19. but was not called out as needing to go back to 4.14.
> > >
> > > Is it possible to pick 3054426dc68e ("sched, trace: Fix prev_state output in sched_switch tracepoint") for the next stable 4.14 release? If not I can do a backport for android-4.14, just let me know.
> >
> > It wasn't backported because it didn't apply cleanly, since 4.4's
> > backport of 3f5fe9fef5b2 differs from Linus's tree.
> >
> > The backport for that commit was done by Sudip (Cc'ed). I'll be happy to
> > take a backport of 3054426dc68e if someone sense one my way.
>
> Happy to do a backport for 4.14-stable. :)
>
> It did not apply before as the function was only renamed by:
> 1d48b080bcce ("sched/debug: Rename task-state printing helpers")
>
> There was no other functionality change.
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2019-02-18 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 12:26 4.14 stable missing 3054426dc68e "sched, trace: Fix prev_state output in sched_switch tracepoint" Chris Redpath
2019-02-18 2:06 ` Sasha Levin
2019-02-18 9:14 ` Sudip Mukherjee
2019-02-18 12:19 ` Greg KH [this message]
2019-02-18 12:34 ` Chris Redpath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218121912.GA30260@kroah.com \
--to=greg@kroah.com \
--cc=Chris.Redpath@arm.com \
--cc=nd@arm.com \
--cc=pkondeti@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox