From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D19A7C43381 for ; Thu, 21 Feb 2019 16:18:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A09F22063F for ; Thu, 21 Feb 2019 16:18:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550765936; bh=ZGiH4xYU0Ch6q8Ff4YeRH9Mh0Zaj4ZDZ9mdzG3ie23U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=o1uyo8xydqZ1SsKrFEpLhVXhvR92LN/vwJITCm1YFL3Ar09KBkVOksiMkTBfWFaOb WjeJruDG16Fu0tM94Cma1uVUByT8sjkSj+UXfV8jzNWso7Vl7rAu0dZRZSyHtI6lc2 SN5OsyXlskkHYLGCVIYlbCR2QgWKzBrRvXr8zwSs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725943AbfBUQSz (ORCPT ); Thu, 21 Feb 2019 11:18:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:38380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfBUQSz (ORCPT ); Thu, 21 Feb 2019 11:18:55 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7CB520836; Thu, 21 Feb 2019 16:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550765935; bh=ZGiH4xYU0Ch6q8Ff4YeRH9Mh0Zaj4ZDZ9mdzG3ie23U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l8wcczNX/DLYYaaJV/5PQ0JzsGwz6LCp4Mopi/3bKwQocTS6Fl54OzI7abD7a1Llj CvcERPbGRuI3xXKWV91EHgBHwJ8GDO5/Hwtevxv8ysGAP9HolvFdOExoCfHV86P8K/ dZXxi46gjpTvEWkx/pkw7mSFvVfhwFaV6pPfeus8= Date: Thu, 21 Feb 2019 17:18:52 +0100 From: Greg Kroah-Hartman To: Willem de Bruijn Cc: stable , David Miller , sashal@kernel.org Subject: Re: net: validate untrusted gso packets without csum offload Message-ID: <20190221161852.GE25800@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Feb 21, 2019 at 10:38:16AM -0500, Willem de Bruijn wrote: > Unfortunately commit > > net: validate untrusted gso packets without csum offload > d5be7f632bad0f489879eed0ff4b99bd7fe0b74c > > needs follow-up > > net: avoid false positives in untrusted gso validation > http://patchwork.ozlabs.org/patch/1044429/ > > It rejects illegal packets injected from userspace, including at > least one that can crash the kernel. But I'm afraid it has false > positives. > > I would suggest holding back on the backport to stable branches until > both patches can go in together. > > If the second patch is not accepted, the alternative will be to revert > this filter-based approach completely and fix the narrow kernel crash > (but I'm afraid that syzkaller will just find others..) > > Apologies for the mess, Ok, I will go drop this patch from all of the stable queues. Can you remind me when your fixup hits Linus's tree so that I can queue up both patches? thanks, greg k-h