From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9F1C43381 for ; Mon, 25 Feb 2019 14:58:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F1382087C for ; Mon, 25 Feb 2019 14:58:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551106693; bh=B8H+zDzogTmoi8MpuyLGZLyyh/mOcKNr0oSY13DQ++E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=P//CGVQma1tpHR3QP1I1Kkod6Vl2djKjQeCqZprVs5SX8PoRbqs5d2KJcAc+mBNbt QX3jdhnduvKDtoP+4xWqT7BqiHm0CANKbxqu7xmaDYrlNCygU9E/x+SVbfu9wZNnmi jIPWmPXPMS6THtpCQs4tcuXorl5bLKM6GvayDKGc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727574AbfBYO6M (ORCPT ); Mon, 25 Feb 2019 09:58:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:41584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727443AbfBYO6M (ORCPT ); Mon, 25 Feb 2019 09:58:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EC962087C; Mon, 25 Feb 2019 14:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551106691; bh=B8H+zDzogTmoi8MpuyLGZLyyh/mOcKNr0oSY13DQ++E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ABg4P9C1Wja5vEMZl0zaQ5p7KimrU+wYPbXwWi7GLvco9MpGf0rZc0xJkAfPECqU+ mSckvYu36xQ1Nu/cmrBc9Imv0iZ0VN7QRIH+TrjX0e673iuTWz216WZE3+0/EHKPYQ DtjTQyQGukdV7iCqtgzjyR7OMDNfjiinHDMlnUPc= Date: Mon, 25 Feb 2019 15:58:09 +0100 From: Greg Kroah-Hartman To: Willem de Bruijn Cc: stable , David Miller , Sasha Levin Subject: Re: net: validate untrusted gso packets without csum offload Message-ID: <20190225145809.GB16015@kroah.com> References: <20190221161852.GE25800@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Feb 24, 2019 at 05:53:16PM -0500, Willem de Bruijn wrote: > On Thu, Feb 21, 2019 at 11:41 AM Willem de Bruijn > wrote: > > > > On Thu, Feb 21, 2019 at 11:18 AM Greg Kroah-Hartman > > wrote: > > > > > > On Thu, Feb 21, 2019 at 10:38:16AM -0500, Willem de Bruijn wrote: > > > > Unfortunately commit > > > > > > > > net: validate untrusted gso packets without csum offload > > > > d5be7f632bad0f489879eed0ff4b99bd7fe0b74c > > > > > > > > needs follow-up > > > > > > > > net: avoid false positives in untrusted gso validation > > > > http://patchwork.ozlabs.org/patch/1044429/ > > > > > > > > It rejects illegal packets injected from userspace, including at > > > > least one that can crash the kernel. But I'm afraid it has false > > > > positives. > > > > > > > > I would suggest holding back on the backport to stable branches until > > > > both patches can go in together. > > > > > > > > If the second patch is not accepted, the alternative will be to revert > > > > this filter-based approach completely and fix the narrow kernel crash > > > > (but I'm afraid that syzkaller will just find others..) > > > > > > > > Apologies for the mess, > > > > > > Ok, I will go drop this patch from all of the stable queues. Can you > > > remind me when your fixup hits Linus's tree so that I can queue up both > > > patches? > > > > Thanks Greg. > > > > Okay, I'll reply to this thread with the follow-up commit SHA1. > > Both patches have now landed in linus's tree > > this patch > > net: validate untrusted gso packets without csum offload > d5be7f632bad0f489879eed0ff4b99bd7fe0b74c > > and its fix > > net: avoid false positives in untrusted gso validation > 9e8db5913264d3967b93c765a6a9e464d9c473db Thanks for letting me know, now queued up. greg k-h