From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F78EC43381 for ; Mon, 25 Feb 2019 15:52:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 090B720C01 for ; Mon, 25 Feb 2019 15:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551109968; bh=IhizRbrHxbWB3H6xPX2sRZ2GlvHQhyFPlBypHLNhMxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xtjlcrY53esQCdlhS27rsgixze9E36yqLtH+z0647llFazgRJ0nonbpKcmoxAET3v yQuJX+dZnvV6to8DWMV8qIsbjlf9ak5hwOJhbw1vbLeVVzAJpX4YtzsPkyeECBrSRy 48i1z2L68gBuUlRQ8yuPnzP2dOB/2ynhRBR5cMss= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727589AbfBYPwr (ORCPT ); Mon, 25 Feb 2019 10:52:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:57086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727505AbfBYPwr (ORCPT ); Mon, 25 Feb 2019 10:52:47 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E35EB20651; Mon, 25 Feb 2019 15:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551109966; bh=IhizRbrHxbWB3H6xPX2sRZ2GlvHQhyFPlBypHLNhMxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dKWnHWqIOoJt5mDDPgM4liT0I1BeKQ1Fl/jHS6v7pymGit7a8B9BTFEp+cujrFJOg 8fs4kWyGq+v/f8wOG+xVh4NdL6xA1cHKiP7omMaRLbkJPhdPuMlvceqivBJ8qUjq14 CbWYS/eEbC2W9tf+28gv4D5QogASDEFGQeuh5la8= Date: Mon, 25 Feb 2019 16:52:43 +0100 From: Greg Kroah-Hartman To: Matthew Wilcox Cc: Gao Xiang , stable@vger.kernel.org, Chao Yu , linux-erofs@lists.ozlabs.org, miaoxie@huawei.com Subject: Re: [PATCH for-4.19 06/12] staging: erofs: fix race when the managed cache is enabled Message-ID: <20190225155243.GB12525@kroah.com> References: <20190220091854.19242-1-gaoxiang25@huawei.com> <20190220091854.19242-7-gaoxiang25@huawei.com> <20190225150449.GD16015@kroah.com> <20190225152548.GA2496@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190225152548.GA2496@bombadil.infradead.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Feb 25, 2019 at 07:25:48AM -0800, Matthew Wilcox wrote: > On Mon, Feb 25, 2019 at 04:04:49PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 20, 2019 at 05:18:48PM +0800, Gao Xiang wrote: > > > commit 51232df5e4b268936beccde5248f312a316800be upstream. > > > Updates: > > > include/linux/xarray.h: > > > add xa_untag_pointer,xa_tag_pointer,xa_pointer_tag > > > from upstream 3159f943aafd in order to reduce > > > conflicts. > > > > No, sorry, I don't want to add xarray.h to 4.19.y, that's crazy. > > I gave this a quick look when it came past, and I don't particularly > object to this piece going into 4.19.y. A full-on backport of XArray > to 4.19 will be ... interesting, but essentially this is just some > boilerplate. > > > And even if we did, you do not slip it in as part of a different patch, > > it should come in as its own patch, with the same git commit id that it > > landed in 4.20 with. > > Putting in all of 3159f943aafdbacb2f94c38fdaadabf2bbde2a14 would be a > bad idea; it actually ended up breaking m68k in a rather unexpected way > which required 66ee620f06f99d72475db6eb638559ba608c7dee, which in turn > caused a memory consumption regression ... Where did the chain of regressions stop? that would be good to know as we will have to deal with this over time :) thanks, greg k-h