From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A78C43381 for ; Mon, 25 Feb 2019 21:20:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C61D2183F for ; Mon, 25 Feb 2019 21:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129617; bh=1GLIRZc7SwxhBVUVsT9KUXOlFCpT5AfD6dD6TRpmJkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kOLTJunIlEVUMWrXi4D0tc721ls07mtDwXYDLWMSrwLK2ZU0pzfRdmuXgoDFMnSR1 OzlYd7698c4TWrg1Ayk6Loa3tIuTzjJQSbibJ2m+L5prT3Z3Xax8iQ2Mw9KLGJ5EiO YnSOVOjWIkn4dFPuktCdz7t8ejT2Qc1r00dzA/Mw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729802AbfBYVT7 (ORCPT ); Mon, 25 Feb 2019 16:19:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:53232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729557AbfBYVT4 (ORCPT ); Mon, 25 Feb 2019 16:19:56 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1D92205C9; Mon, 25 Feb 2019 21:19:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551129596; bh=1GLIRZc7SwxhBVUVsT9KUXOlFCpT5AfD6dD6TRpmJkw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XIoMhfrQmELAWwg0PjqC6++9IPC3PC805MltFEhU1eKHI7rsxEYIKsWHzXic4cbq7 z4Iy8Ob+fdlUACfRqjFSQP4Lw12u3PiwvL49RJyPmMQUaSnW3ll3PXJGQHc3hxMo5D IPVAI7TgMzdOsa2kALESGDNZi6y3e9gDLIK7gUhU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Yan, Zheng" , Ilya Dryomov Subject: [PATCH 4.19 010/152] ceph: avoid repeatedly adding inode to mdsc->snap_flush_list Date: Mon, 25 Feb 2019 22:10:02 +0100 Message-Id: <20190225195044.358245683@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190225195043.645958524@linuxfoundation.org> References: <20190225195043.645958524@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yan, Zheng commit 04242ff3ac0abbaa4362f97781dac268e6c3541a upstream. Otherwise, mdsc->snap_flush_list may get corrupted. Cc: stable@vger.kernel.org Signed-off-by: "Yan, Zheng" Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/snap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/ceph/snap.c +++ b/fs/ceph/snap.c @@ -616,7 +616,8 @@ int __ceph_finish_cap_snap(struct ceph_i capsnap->size); spin_lock(&mdsc->snap_flush_lock); - list_add_tail(&ci->i_snap_flush_item, &mdsc->snap_flush_list); + if (list_empty(&ci->i_snap_flush_item)) + list_add_tail(&ci->i_snap_flush_item, &mdsc->snap_flush_list); spin_unlock(&mdsc->snap_flush_lock); return 1; /* caller may want to ceph_flush_snaps */ }