* stable request: 186b8f15 ("powerpc: Always initialize input array when calling epapr_hypercall()")
@ 2019-03-02 20:24 Thomas Deutschmann
2019-03-02 21:21 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Deutschmann @ 2019-03-02 20:24 UTC (permalink / raw)
To: stable; +Cc: seth.forshee, mpe
[-- Attachment #1.1: Type: text/plain, Size: 1107 bytes --]
Hi,
please backport
> powerpc: Always initialize input array when calling epapr_hypercall()
> Several callers to epapr_hypercall() pass an uninitialized stack
> allocated array for the input arguments, presumably because they
> have no input arguments. However this can produce errors like
> this one
>
> arch/powerpc/include/asm/epapr_hcalls.h:470:42: error: 'in' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> unsigned long register r3 asm("r3") = in[0];
> ~~^~~
>
> Fix callers to this function to always zero-initialize the input
> arguments array to prevent this.
>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=186b8f1587c79c2fa04bfa392fdf084443e398c1
to
- 4.14.x
- 4.9.x
- 4.4.x
Downstream-Bug: https://bugs.gentoo.org/675334
--
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: stable request: 186b8f15 ("powerpc: Always initialize input array when calling epapr_hypercall()")
2019-03-02 20:24 stable request: 186b8f15 ("powerpc: Always initialize input array when calling epapr_hypercall()") Thomas Deutschmann
@ 2019-03-02 21:21 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-03-02 21:21 UTC (permalink / raw)
To: Thomas Deutschmann; +Cc: stable, seth.forshee, mpe
On Sat, Mar 02, 2019 at 09:24:21PM +0100, Thomas Deutschmann wrote:
> Hi,
>
> please backport
>
> > powerpc: Always initialize input array when calling epapr_hypercall()
> > Several callers to epapr_hypercall() pass an uninitialized stack
> > allocated array for the input arguments, presumably because they
> > have no input arguments. However this can produce errors like
> > this one
> >
> > arch/powerpc/include/asm/epapr_hcalls.h:470:42: error: 'in' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > unsigned long register r3 asm("r3") = in[0];
> > ~~^~~
> >
> > Fix callers to this function to always zero-initialize the input
> > arguments array to prevent this.
> >
> > Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=186b8f1587c79c2fa04bfa392fdf084443e398c1
>
> to
>
> - 4.14.x
> - 4.9.x
> - 4.4.x
>
>
> Downstream-Bug: https://bugs.gentoo.org/675334
It's already queued up for the next round of stable releases, no need to
ask again :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-02 21:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-02 20:24 stable request: 186b8f15 ("powerpc: Always initialize input array when calling epapr_hypercall()") Thomas Deutschmann
2019-03-02 21:21 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).