From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEB4DC43381 for ; Mon, 4 Mar 2019 08:46:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E10C20823 for ; Mon, 4 Mar 2019 08:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551689160; bh=txqcuwmtT5F9dt+WPMDsEGvpf1APfWIw552UwJQQoJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XH3m7N5mxyoaPGZV1ZWX8kjph95gXGK0G7IbbhlcI2YKRyqCxberR8odc5/ejBATN ero7didYqMIWZHHKJ8mMa3+qsf1byIJ0JiNJ9N0YYR0W/j1m2N4U9JTFvsQGbGUAJi 9R1uH0TnZfox52bPPv4Xmgm2cYddvMevFZWGHXSk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbfCDIpy (ORCPT ); Mon, 4 Mar 2019 03:45:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:50530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727224AbfCDI1S (ORCPT ); Mon, 4 Mar 2019 03:27:18 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C4E7D20836; Mon, 4 Mar 2019 08:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551688038; bh=txqcuwmtT5F9dt+WPMDsEGvpf1APfWIw552UwJQQoJ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KYT4mrNJohihu2JnMAiod9FVcoL478XLNs5h0yfTWd68Sgpo/R4r6wJ4MLK8jsST4 utPQ4aEJjk6TwzBdsQK07ibA4d/LY7qZfgYW20GdMkT14ih08WO7mC+UjdUDVKPjBq BsMeWpq98GV1C1ZW7djHHYHUMgKTDKDgbKXjZ9+U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Felipe Balbi , Sasha Levin Subject: [PATCH 4.14 15/52] usb: gadget: Potential NULL dereference on allocation error Date: Mon, 4 Mar 2019 09:22:13 +0100 Message-Id: <20190304081617.982472968@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190304081617.159014799@linuxfoundation.org> References: <20190304081617.159014799@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit df28169e1538e4a8bcd8b779b043e5aa6524545c ] The source_sink_alloc_func() function is supposed to return error pointers on error. The function is called from usb_get_function() which doesn't check for NULL returns so it would result in an Oops. Of course, in the current kernel, small allocations always succeed so this doesn't affect runtime. Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/function/f_sourcesink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c index 8784fa12ea2c6..6e9d958004a0d 100644 --- a/drivers/usb/gadget/function/f_sourcesink.c +++ b/drivers/usb/gadget/function/f_sourcesink.c @@ -842,7 +842,7 @@ static struct usb_function *source_sink_alloc_func( ss = kzalloc(sizeof(*ss), GFP_KERNEL); if (!ss) - return NULL; + return ERR_PTR(-ENOMEM); ss_opts = container_of(fi, struct f_ss_opts, func_inst); -- 2.19.1