From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B7CC43381 for ; Mon, 4 Mar 2019 08:44:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1FC62082F for ; Mon, 4 Mar 2019 08:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551689081; bh=lO+cejBiOVsCiUSi7JGImVx2OpmF4fcUnylOXprrC+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ycgl219y++CeeLu2B+7UWZjm+SXs/OXMPK7/3mXuuG4aR8HTPB4sYF2RNVYFg8OWD HE6teKVVdrsQ3XdqwC/rD8BGYQeTOjCCq6QdLckRTNh73fyFgYF9qY5gseL8dd/mvG Cru0jaiX6rsKmaxyRikSOW2z5bWf9/RWg6Tk5aIc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726878AbfCDI2m (ORCPT ); Mon, 4 Mar 2019 03:28:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:54020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727121AbfCDI2j (ORCPT ); Mon, 4 Mar 2019 03:28:39 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9DBDA208E4; Mon, 4 Mar 2019 08:28:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551688119; bh=lO+cejBiOVsCiUSi7JGImVx2OpmF4fcUnylOXprrC+Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j4xVuv8s6Ved3MJDiOznI3ZEOJFTT6SbA1BEWIBhCg8RasPyG95qcKq46YsdVxEbQ UnD+isj/reOm8Y6xKTpKElWDtxcaJZk/q0cus3bDnWsrDaXU9S/3y3sEIpZu0nNcRv viw3DeO8XBbQP+N+VNqnz7w2qNpXQc1i7GVomvB8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yizhuo , Mark Brown , Sasha Levin Subject: [PATCH 4.19 09/78] ASoC: Variable "val" in function rt274_i2c_probe() could be uninitialized Date: Mon, 4 Mar 2019 09:21:52 +0100 Message-Id: <20190304081625.912562513@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190304081625.508788074@linuxfoundation.org> References: <20190304081625.508788074@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 8c3590de0a378c2449fc1aec127cc693632458e4 ] Inside function rt274_i2c_probe(), if regmap_read() function returns -EINVAL, then local variable "val" leaves uninitialized but used in if statement. This is potentially unsafe. Signed-off-by: Yizhuo Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/rt274.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c index d88e673410835..18a931c25ca58 100644 --- a/sound/soc/codecs/rt274.c +++ b/sound/soc/codecs/rt274.c @@ -1126,8 +1126,11 @@ static int rt274_i2c_probe(struct i2c_client *i2c, return ret; } - regmap_read(rt274->regmap, + ret = regmap_read(rt274->regmap, RT274_GET_PARAM(AC_NODE_ROOT, AC_PAR_VENDOR_ID), &val); + if (ret) + return ret; + if (val != RT274_VENDOR_ID) { dev_err(&i2c->dev, "Device with ID register %#x is not rt274\n", val); -- 2.19.1