From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH 4.19 16/78] usb: gadget: Potential NULL dereference on allocation error
Date: Mon, 4 Mar 2019 09:21:59 +0100 [thread overview]
Message-ID: <20190304081626.229188629@linuxfoundation.org> (raw)
In-Reply-To: <20190304081625.508788074@linuxfoundation.org>
4.19-stable review patch. If anyone has any objections, please let me know.
------------------
[ Upstream commit df28169e1538e4a8bcd8b779b043e5aa6524545c ]
The source_sink_alloc_func() function is supposed to return error
pointers on error. The function is called from usb_get_function() which
doesn't check for NULL returns so it would result in an Oops.
Of course, in the current kernel, small allocations always succeed so
this doesn't affect runtime.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/usb/gadget/function/f_sourcesink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c
index 9cdef108fb1b3..ed68a4860b7d8 100644
--- a/drivers/usb/gadget/function/f_sourcesink.c
+++ b/drivers/usb/gadget/function/f_sourcesink.c
@@ -838,7 +838,7 @@ static struct usb_function *source_sink_alloc_func(
ss = kzalloc(sizeof(*ss), GFP_KERNEL);
if (!ss)
- return NULL;
+ return ERR_PTR(-ENOMEM);
ss_opts = container_of(fi, struct f_ss_opts, func_inst);
--
2.19.1
next prev parent reply other threads:[~2019-03-04 8:42 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 8:21 [PATCH 4.19 00/78] 4.19.27-stable review Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 01/78] irq/matrix: Split out the CPU selection code into a helper Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 02/78] irq/matrix: Spread managed interrupts on allocation Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 03/78] genirq/matrix: Improve target CPU selection for managed interrupts Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 04/78] mac80211: Change default tx_sk_pacing_shift to 7 Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 05/78] scsi: libsas: Fix rphy phy_identifier for PHYs with end devices attached Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 06/78] drm/msm: Unblock writer if reader closes file Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 07/78] ASoC: Intel: Haswell/Broadwell: fix setting for .dynamic field Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 08/78] ALSA: compress: prevent potential divide by zero bugs Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 09/78] ASoC: Variable "val" in function rt274_i2c_probe() could be uninitialized Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 10/78] clk: tegra: dfll: Fix a potential Oop in remove() Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 11/78] clk: sysfs: fix invalid JSON in clk_dump Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 12/78] clk: vc5: Abort clock configuration without upstream clock Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 13/78] thermal: int340x_thermal: Fix a NULL vs IS_ERR() check Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 14/78] usb: dwc3: gadget: synchronize_irq dwc irq in suspend Greg Kroah-Hartman
2019-03-04 8:21 ` [PATCH 4.19 15/78] usb: dwc3: gadget: Fix the uninitialized link_state when udc starts Greg Kroah-Hartman
2019-03-04 8:21 ` Greg Kroah-Hartman [this message]
2019-03-04 8:22 ` [PATCH 4.19 17/78] selftests: rtc: rtctest: fix alarm tests Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 18/78] selftests: rtc: rtctest: add alarm test on minute boundary Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 19/78] genirq: Make sure the initial affinity is not empty Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 20/78] x86/mm/mem_encrypt: Fix erroneous sizeof() Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 21/78] ASoC: rt5682: Fix PLL source register definitions Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 22/78] ASoC: dapm: change snprintf to scnprintf for possible overflow Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 23/78] ASoC: imx-audmux: " Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 24/78] selftests/vm/gup_benchmark.c: match gup struct to kernel Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 25/78] phy: ath79-usb: Fix the power on error path Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 26/78] phy: ath79-usb: Fix the main reset name to match the DT binding Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 27/78] selftests: seccomp: use LDLIBS instead of LDFLAGS Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 28/78] selftests: gpio-mockup-chardev: Check asprintf() for error Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 29/78] irqchip/gic-v3-mbi: Fix uninitialized mbi_lock Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 30/78] ARC: fix __ffs return value to avoid build warnings Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 31/78] ARC: show_regs: lockdep: avoid page allocator Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 32/78] drivers: thermal: int340x_thermal: Fix sysfs race condition Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 33/78] staging: rtl8723bs: Fix build error with Clang when inlining is disabled Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 34/78] mac80211: fix miscounting of ttl-dropped frames Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 35/78] sched/wait: Fix rcuwait_wake_up() ordering Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 36/78] sched/wake_q: Fix wakeup ordering for wake_q Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 37/78] futex: Fix (possible) missed wakeup Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 38/78] locking/rwsem: " Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 39/78] drm/amd/powerplay: OD setting fix on Vega10 Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 40/78] tty: serial: qcom_geni_serial: Allow mctrl when flow control is disabled Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 41/78] serial: fsl_lpuart: fix maximum acceptable baud rate with over-sampling Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 42/78] drm/sun4i: hdmi: Fix usage of TMDS clock Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 43/78] staging: android: ion: Support cpu access during dma_buf_detach Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 44/78] direct-io: allow direct writes to empty inodes Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 45/78] writeback: synchronize sync(2) against cgroup writeback membership switches Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 46/78] scsi: lpfc: nvme: avoid hang / use-after-free when destroying localport Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 47/78] scsi: lpfc: nvmet: avoid hang / use-after-free when destroying targetport Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 48/78] scsi: csiostor: fix NULL pointer dereference in csio_vport_set_state() Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 49/78] net: altera_tse: fix connect_local_phy error path Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 50/78] hv_netvsc: Fix ethtool change hash key error Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 51/78] hv_netvsc: Refactor assignments of struct netvsc_device_info Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 52/78] hv_netvsc: Fix hash key value reset after other ops Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 53/78] nvme-rdma: fix timeout handler Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 54/78] nvme-multipath: drop optimization for static ANA group IDs Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 55/78] drm/msm: Fix A6XX support for opp-level Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 56/78] net: usb: asix: ax88772_bind return error when hw_reset fail Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 57/78] net: dev_is_mac_header_xmit() true for ARPHRD_RAWIP Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 58/78] ibmveth: Do not process frames after calling napi_reschedule Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 59/78] mac80211: dont initiate TDLS connection if station is not associated to AP Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 60/78] mac80211: Add attribute aligned(2) to struct action Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 61/78] cfg80211: extend range deviation for DMG Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 62/78] svm: Fix AVIC incomplete IPI emulation Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 63/78] KVM: nSVM: clear events pending from svm_complete_interrupts() when exiting to L1 Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 64/78] kvm: selftests: Fix region overlap check in kvm_util Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 65/78] mmc: spi: Fix card detection during probe Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 66/78] mmc: tmio_mmc_core: dont claim spurious interrupts Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 67/78] mmc: tmio: fix access width of Block Count Register Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 68/78] mmc: core: Fix NULL ptr crash from mmc_should_fail_request Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 69/78] mmc: cqhci: fix space allocated for transfer descriptor Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 70/78] mmc: cqhci: Fix a tiny potential memory leak on error condition Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 71/78] mmc: sdhci-esdhc-imx: correct the fix of ERR004536 Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 72/78] mm: enforce min addr even if capable() in expand_downwards() Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 73/78] drm: Block fb changes for async plane updates Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 74/78] hugetlbfs: fix races and page leaks during migration Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 75/78] MIPS: fix truncation in __cmpxchg_small for short values Greg Kroah-Hartman
2019-03-04 8:22 ` [PATCH 4.19 76/78] MIPS: BCM63XX: provide DMA masks for ethernet devices Greg Kroah-Hartman
2019-03-04 8:23 ` [PATCH 4.19 77/78] MIPS: eBPF: Fix icache flush end address Greg Kroah-Hartman
2019-03-04 8:23 ` [PATCH 4.19 78/78] x86/uaccess: Dont leak the AC flag into __put_user() value evaluation Greg Kroah-Hartman
2019-03-04 19:09 ` [PATCH 4.19 00/78] 4.19.27-stable review Naresh Kamboju
2019-03-05 3:39 ` Guenter Roeck
2019-03-05 14:07 ` Jon Hunter
2019-03-05 16:19 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304081626.229188629@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).