From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9124C43381 for ; Wed, 6 Mar 2019 18:47:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EEAE20661 for ; Wed, 6 Mar 2019 18:47:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kNbNAaUh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727889AbfCFSro (ORCPT ); Wed, 6 Mar 2019 13:47:44 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:37039 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727903AbfCFSro (ORCPT ); Wed, 6 Mar 2019 13:47:44 -0500 Received: by mail-qt1-f194.google.com with SMTP id a48so14059663qtb.4 for ; Wed, 06 Mar 2019 10:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ieuYAOulG+S2P49CA8K9vGFMJZkZKzKWQN1XYIR2iGw=; b=kNbNAaUhWNMrRDOZfTX8wHqxwRLi8vPaTaGZY87taFQPtiktzpQ8J2Hun6lBrcz79D aTP/897wsg8EFWH0RCeM0p3s72C4NY7OHj5BCnJyl++ltMb2M3wE7bMTsPVEzPPqICxz VYl/w2DK8jJ6H6FzfWm1t50vu54LmMojqgWWdODf1tRpV0BXxYOo3rnWWm3a7HsjBx4c aIVmtAK9jHF8SG85n/EHmVPGZ56ZBd7tG7simPxLmXGcJHd1VumZcRmGvg2A1StWF97t qMw6RhgTnto/h+NDb9hZGS1AMZlSJ+/2alPJhTkxzQkmApy+WMaSLi1tSn2EX/nSjSKE KKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ieuYAOulG+S2P49CA8K9vGFMJZkZKzKWQN1XYIR2iGw=; b=hvTd2QxzBl1nXVGBbJlBMNjwUa3yw8dWPeloD37SaHFdqwv/8rpUvtNbPzM+rjJnRg KoaBWelg0FQh83pjaDK2TXxOh2G5XgKN5H/JEM1VPWio+kdg82SQmvHBEgdOcjPBeyqC 3vtjg1a4I1JB40Y7tYQzv6+ZBHXWN4alN4iv7Lwt9BDlQpSlUVre9ri5UjFp5OqLTC7j 4fppT04GRV97lRmtciRCqDfeo3ZXh12nFqHCPYykWOpAMvmgCxFU3sDPLAk5oN5i2qfN PcHD4sCnB+tq0eCn2m51tQIFUmonLoYwqTQryobcivnr+kePz0S9CzUEF6hvv0YRu+Ml tTMg== X-Gm-Message-State: APjAAAXNH4o8+sLVY5TLUs6ZhZpX0ODvEzh/T6sVt6iMvIN0h5C2IUeL EbB8DbjpN8uc5XyMC6QOQ6he0wi0FTA= X-Google-Smtp-Source: APXvYqxlkOBB2qsJ9nsC2rj+dJZfE0C/o8zDK9LC+Q3HBPAb4lY43TqmOiqkbVwaNSigSM6MIidxIg== X-Received: by 2002:ac8:3896:: with SMTP id f22mr6763438qtc.324.1551898062755; Wed, 06 Mar 2019 10:47:42 -0800 (PST) Received: from ziepe.ca ([24.137.65.181]) by smtp.gmail.com with ESMTPSA id x17sm1339279qka.94.2019.03.06.10.47.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Mar 2019 10:47:42 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1h1bZs-0008WR-Sj; Wed, 06 Mar 2019 14:47:40 -0400 Date: Wed, 6 Mar 2019 14:47:40 -0400 From: Jason Gunthorpe To: Dennis Dalessandro Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, "Michael J. Ruhl" , Mike Marciniszyn , stable@vger.kernel.org Subject: Re: [PATCH for-next 3/3] IB/hfi1: Close race condition on user context disable and close Message-ID: <20190306184740.GH1662@ziepe.ca> References: <20190226164333.31476.43732.stgit@scvm10.sc.intel.com> <20190226164530.31476.26502.stgit@scvm10.sc.intel.com> <316cda1d-eeaa-c75a-a4d8-fb087cd38714@intel.com> <20190304204153.GF8613@ziepe.ca> <03a0a78b-8ae6-26b2-7d6c-9d605971d975@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03a0a78b-8ae6-26b2-7d6c-9d605971d975@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Mar 05, 2019 at 10:30:39AM -0500, Dennis Dalessandro wrote: > On 3/4/2019 3:41 PM, Jason Gunthorpe wrote: > > On Tue, Feb 26, 2019 at 12:15:59PM -0500, Dennis Dalessandro wrote: > > > On 2/26/2019 11:45 AM, Dennis Dalessandro wrote: > > > > struct hfi1_ctxtdata *hfi1_rcd_get_by_index(struct hfi1_devdata *dd, u16 ctxt); > > > > diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c > > > > index 7841a0a..2cc5164 100644 > > > > +++ b/drivers/infiniband/hw/hfi1/init.c > > > > @@ -214,12 +214,12 @@ static void hfi1_rcd_free(struct kref *kref) > > > > struct hfi1_ctxtdata *rcd = > > > > container_of(kref, struct hfi1_ctxtdata, kref); > > > > - hfi1_free_ctxtdata(rcd->dd, rcd); > > > > - > > > > spin_lock_irqsave(&rcd->dd->uctxt_lock, flags); > > > > rcd->dd->rcd[rcd->ctxt] = NULL; > > > > spin_unlock_irqrestore(&rcd->dd->uctxt_lock, flags); > > > > + hfi1_free_ctxtdata(rcd->dd, rcd); > > > > + > > > > kfree(rcd); > > > > } > > > Whoops, hold off on pulling this one just yet. We need to take a closer look > > > at the above hunk. > > > > Oh, okay.. Please resend it > > We've talked it over, it is OK to take after all. Just needed to be sure and > folks were on vacation last week. If you still have the patch it's good to > go, if not I'll tack it on my next submit as well. Okay I grabbed the old one Jason