From: Greg KH <gregkh@linuxfoundation.org>
To: Thibaut Sautereau <thibaut@sautereau.fr>
Cc: stable@vger.kernel.org,
Thibaut Sautereau <thibaut.sautereau@clip-os.org>,
YueHaibing <yuehaibing@huawei.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] exec: Fix mem leak in kernel_read_file
Date: Fri, 8 Mar 2019 13:40:39 +0100 [thread overview]
Message-ID: <20190308124039.GC13818@kroah.com> (raw)
In-Reply-To: <20190305090039.GB3189@gandi.net>
On Tue, Mar 05, 2019 at 10:00:39AM +0100, Thibaut Sautereau wrote:
> On Tue, Mar 05, 2019 at 07:20:20AM +0100, Greg KH wrote:
> > On Mon, Mar 04, 2019 at 11:17:38PM +0100, Thibaut Sautereau wrote:
> > > Commit f612acfae86af7ecad754ae6a46019be9da05b8e upstream
> > > ("exec: Fix mem leak in kernel_read_file"), addressing CVE-2019-8980,
> > > should be applied to 4.20, 4.19, 4.14 and 4.9 stable kernels.
> >
> > Any reason you didn't cc: the authors of that patch?
>
> No, I just forgot, sorry for that.
>
> > And as it _just_ went into Linus's tree today, give us a few weeks to
> > get it backported...
> >
> > Also, it's just a "normal" syzbot fix, for a very rare case, why is this
> > a CVE?
>
> I don't know (I'm not the one who requested a CVE), but I saw that this
> patch had been backported in Arch Linux's kernels to address
> CVE-2019-8980 [1] and that stable@kernel.org hadn't been put in Cc:.
>
> As the fix was already waiting in a pull-request [2] from Al Viro, I
> thought it was too late to notice the author about Ccing stable,
> therefore I followed option 2 of
> Documentation/process/stable-kernel-rules.rst to ensure it would not
> fall through the cracks.
>
> If that was the wrong way to do it, please tell me what I should have
> done in this case.
No, this is fine, just next time you should cc: the developers as well.
Also, this needs to go to 5.0.y, now queued up.
greg k-h
prev parent reply other threads:[~2019-03-08 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-04 22:17 [PATCH] exec: Fix mem leak in kernel_read_file Thibaut Sautereau
2019-03-05 6:20 ` Greg KH
2019-03-05 9:00 ` Thibaut Sautereau
2019-03-08 12:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308124039.GC13818@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=thibaut.sautereau@clip-os.org \
--cc=thibaut@sautereau.fr \
--cc=viro@zeniv.linux.org.uk \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).