From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C774C43381 for ; Fri, 8 Mar 2019 13:07:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 531E820661 for ; Fri, 8 Mar 2019 13:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552050471; bh=VnQrJniqRbYxTeSMMNyZvBs9zvh8wDZED5xINcviBAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o0qhDRdaF8rdvxIuCzCCKVk7Iqb1sBcPZ/l6Bd/8alz3Qo6qWTvP9KSBAJkj54Bqo EqUo/Pbh2CLCgX5bVwtl0xtl4AzlPbp7jy5Lrn+/6CiHzZQdy4kldFCCq1Fh9dYvIY x/93DVgJjYQ077Q5zAVnXqFwy/KtVsD+9gnyd200= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727195AbfCHMxo (ORCPT ); Fri, 8 Mar 2019 07:53:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:57378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbfCHMxn (ORCPT ); Fri, 8 Mar 2019 07:53:43 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC5CD2085A; Fri, 8 Mar 2019 12:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552049623; bh=VnQrJniqRbYxTeSMMNyZvBs9zvh8wDZED5xINcviBAc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MyiJdAQ57cPFyPhxK2EEVXK4fyyteZ3++PXNWXtndhTnuo7B36CnHMM+tiLPBu3x8 BqSOC6kPKHLaYrMua4ozdgVWjxXJ3D6TUqRrY5SnufR1/Zh8AlBEqNlbY5iQsGKoRY 82LwHQlQg0H2rPgLBJmADLEyw1EnmW1onCn3eZ1k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Ian Abbott Subject: [PATCH 4.20 13/76] staging: comedi: ni_660x: fix missing break in switch statement Date: Fri, 8 Mar 2019 13:49:25 +0100 Message-Id: <20190308124915.250572781@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190308124914.789210760@linuxfoundation.org> References: <20190308124914.789210760@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gustavo A. R. Silva commit 479826cc86118e0d87e5cefb3df5b748e0480924 upstream. Add missing break statement in order to prevent the code from falling through to the default case and return -EINVAL every time. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: aa94f2888825 ("staging: comedi: ni_660x: tidy up ni_660x_set_pfi_routing()") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_660x.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/comedi/drivers/ni_660x.c +++ b/drivers/staging/comedi/drivers/ni_660x.c @@ -656,6 +656,7 @@ static int ni_660x_set_pfi_routing(struc case NI_660X_PFI_OUTPUT_DIO: if (chan > 31) return -EINVAL; + break; default: return -EINVAL; }