From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9164CC43381 for ; Tue, 12 Mar 2019 12:39:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D3032147C for ; Tue, 12 Mar 2019 12:39:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="Hxb4Z8bl"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="YgFA9WTV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725894AbfCLMjh (ORCPT ); Tue, 12 Mar 2019 08:39:37 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:44601 "EHLO wout2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfCLMjh (ORCPT ); Tue, 12 Mar 2019 08:39:37 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 4E4E935AA; Tue, 12 Mar 2019 08:39:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 12 Mar 2019 08:39:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=BOrFzwgTydl+GTeUseOZMdpaAFQ X2ZF3uM6kf5z+7aU=; b=Hxb4Z8blrmwO/qm14hGaWFiF2kBrQy3nbiBFUNXyTws f2Q3Ky1TF18+zVJv0bTe3gq8XoNPOiVtjt6MYtRoi9jQboSIwxb+zXxghqAN1gBI 8RfbwyosvH3/FgUiXJXwWZHH/cBst1LLuiXC6pXPk42uxMDyn1v5FXQY/mwHbQ40 ug8fAtP7rVHH8G6QrAki+ZvUXNzcIrYa+Y/4CAFHM0GEZJXoDYjY3XbyJ8JMP30K TVHxTD9H6RarkQDdM1XROZhQT9+KhGpoLRoGetFKgeO18S5EGiVwqiNmKW79kjFM nYbNMLjFVAjy291cRlIqBPY5t0KDx24GubrLROYkhYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BOrFzw gTydl+GTeUseOZMdpaAFQX2ZF3uM6kf5z+7aU=; b=YgFA9WTV2hxQu0TzUyZtky yjNGo8oBuNcGZz3b5+t7z0LBGWddmBiNpp13WkhdY/lfH4MPPLe7KyXqOFwO3dXT +jENI21jBGLaPCSxuVv21IVKge/Exfiohw0e41X7ix7dWV3ZDqve1c4ksPBce7g5 DclQ822kG2Bqvqda1rT0KBr7yu+pvZHrZrLrRjroN4gB1tuRM4vmSFnSsFyawFL8 dG5BEUD64gOgvYrdmPRXiNgJHM4g4jGd2tCmLxA1G1hx3M9B5JAxo+Q7pPCKeeaY SV/aNbhOe1nYDuvlMCh1JxF/omOSb0QXq1rD36hUR3aw5+qX0en2n1djf0OsxUCw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrgeekgdegfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepuddvrddvjedrieehrddvvd dunecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (unknown [12.27.65.221]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A3651033A; Tue, 12 Mar 2019 08:39:34 -0400 (EDT) Date: Tue, 12 Mar 2019 05:39:34 -0700 From: Greg KH To: Krzysztof Kozlowski Cc: stable@vger.kernel.org Subject: Re: [PATCH stable v4.9+] ARM: dts: exynos: Do not ignore real-world fuse values for thermal zone 0 on Exynos5420 Message-ID: <20190312123934.GA14713@kroah.com> References: <1552393563-3337-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1552393563-3337-1-git-send-email-krzk@kernel.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Mar 12, 2019 at 01:26:03PM +0100, Krzysztof Kozlowski wrote: > commit 28928a3ce142b2e4e5a7a0f067cefb41a3d2c3f9 upstream. > > In Odroid XU3 Lite board, the temperature levels reported for thermal > zone 0 were weird. In warm room: > /sys/class/thermal/thermal_zone0/temp:32000 > /sys/class/thermal/thermal_zone1/temp:51000 > /sys/class/thermal/thermal_zone2/temp:55000 > /sys/class/thermal/thermal_zone3/temp:54000 > /sys/class/thermal/thermal_zone4/temp:51000 > > Sometimes after booting the value was even equal to ambient temperature > which is highly unlikely to be a real temperature of sensor in SoC. > > The thermal sensor's calibration (trimming) is based on fused values. > In case of the board above, the fused values are: 35, 52, 43, 58 and 43 > (corresponding to each TMU device). However driver defined a minimum value > for fused data as 40 and for smaller values it was using a hard-coded 55 > instead. This lead to mapping data from sensor to wrong temperatures > for thermal zone 0. > > Various vendor 3.10 trees (Hardkernel's based on Samsung LSI, Artik 10) > do not impose any limits on fused values. Since we do not have any > knowledge about these limits, use 0 as a minimum accepted fused value. > This should essentially allow accepting any reasonable fused value thus > behaving like vendor driver. > > The exynos5420-tmu-sensor-conf.dtsi is copied directly from existing > exynos4412 with one change - the samsung,tmu_min_efuse_value. > > Signed-off-by: Krzysztof Kozlowski > Acked-by: Bartlomiej Zolnierkiewicz > Acked-by: Eduardo Valentin > Reviewed-by: Javier Martinez Canillas > Tested-by: Javier Martinez Canillas > Reviewed-by: Anand Moon > Tested-by: Anand Moon > --- > arch/arm/boot/dts/exynos5420-tmu-sensor-conf.dtsi | 25 +++++++++++++++++++++++ > arch/arm/boot/dts/exynos5420.dtsi | 10 ++++----- > 2 files changed, 30 insertions(+), 5 deletions(-) > create mode 100644 arch/arm/boot/dts/exynos5420-tmu-sensor-conf.dtsi Looks good, now queued up along with the 4.4.y version. greg k-h