From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53067C43381 for ; Tue, 12 Mar 2019 18:05:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A2712147C for ; Tue, 12 Mar 2019 18:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552413914; bh=8IfmPEyHmslxKt59XpZTWy9lmBPPVN6c06+wGZVna50=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1DQCLg9hFuUaF88TJH5NuA4EUfwLgvoUFx/Y6elZ9R4cUldvunXesesJX8N7i1hGE KecePa3++4fK8C1r6vq+RLyiKmPo81kicPHqVuoHRr7P+nqQkTMWLg+RQSSKYyUqbH eOyKJPIh5SfW/J8wrJ2DxHz/JzVUelnnmUMKVajQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727603AbfCLSFN (ORCPT ); Tue, 12 Mar 2019 14:05:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:48336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727590AbfCLRMl (ORCPT ); Tue, 12 Mar 2019 13:12:41 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DDF50217F9; Tue, 12 Mar 2019 17:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552410761; bh=8IfmPEyHmslxKt59XpZTWy9lmBPPVN6c06+wGZVna50=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KxEtyxrKvCaizQ9bB87bI1/wjsNnA2p6Kwt3LMfV8VVBU9e3MF6TyStTY7DgePoZf gw3KuC8rLKVfnC8efSO6mJVBC+cjLMBHHJOEZirl0Q4PZKWuG7rriTp/fNIwAibJtF P73+wqsWBIo+cgTArm23AkYgFI8RLh8845SqBSCI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Felix Fietkau , Sven Eckelmann , Simon Wunderlich , Sasha Levin Subject: [PATCH 4.20 093/171] batman-adv: release station info tidstats Date: Tue, 12 Mar 2019 10:07:53 -0700 Message-Id: <20190312170355.976935399@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170347.868927101@linuxfoundation.org> References: <20190312170347.868927101@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 7d652669b61d702c6e62a39579d17f6881670ab6 ] With the addition of TXQ stats in the per-tid statistics the struct station_info grew significantly. This resulted in stack size warnings due to the structure itself being above the limit for the warnings. To work around this, the TID array was allocated dynamically. Also a function to free this content was introduced with commit 7ea3e110f2f8 ("cfg80211: release station info tidstats where needed") but the necessary changes were not provided for batman-adv's B.A.T.M.A.N. V implementation. Signed-off-by: Felix Fietkau Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info") [sven@narfation.org: add commit message] Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich Signed-off-by: Sasha Levin --- net/batman-adv/bat_v_elp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/batman-adv/bat_v_elp.c b/net/batman-adv/bat_v_elp.c index e8090f099eb8..ef0dec20c7d8 100644 --- a/net/batman-adv/bat_v_elp.c +++ b/net/batman-adv/bat_v_elp.c @@ -104,6 +104,9 @@ static u32 batadv_v_elp_get_throughput(struct batadv_hardif_neigh_node *neigh) ret = cfg80211_get_station(real_netdev, neigh->addr, &sinfo); + /* free the TID stats immediately */ + cfg80211_sinfo_release_content(&sinfo); + dev_put(real_netdev); if (ret == -ENOENT) { /* Node is not associated anymore! It would be -- 2.19.1