From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B40C4360F for ; Tue, 12 Mar 2019 18:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A600214AF for ; Tue, 12 Mar 2019 18:00:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552413624; bh=6XNrrTvVy1QOul8jqwharAlHnm4MW6mbR65A/bL3Hqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=H4hrIt+FstBql3A19zaus6eGwewRgMIWQN6IMg07Q/Q0MTiF3K+h2z0E9wIuOuqAo 2O/LqhzJc/O6Mdl5a1xsDrZlJ+ovIDkxaVEMWSk2hXUBdoD8XcIRw9/2BZAeJbtr7j IMoBymsQyrBDMGj0tfphYrZSTTmKrLRmt0ED0DTU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728088AbfCLSAX (ORCPT ); Tue, 12 Mar 2019 14:00:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:50364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727088AbfCLRNZ (ORCPT ); Tue, 12 Mar 2019 13:13:25 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D794E217D4; Tue, 12 Mar 2019 17:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552410805; bh=6XNrrTvVy1QOul8jqwharAlHnm4MW6mbR65A/bL3Hqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L8CvJy3s3u72vZ4T45XmY5l0vahOQwOeaEy0af4210X7fTBNQxUEwyoVeXRJnOumh Vw+wxogoEMdDa7L1oYTaihjIdOBReBy+JSDP6Xr7cnTSuVwYbRfqokciDAdnUuvS9E QHS1ydlhUhQ9kAifqAp+cljnZOYjhYXCgApZTtC4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ross Lagerwall , Hannes Reinecke , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.20 133/171] Revert "scsi: libfc: Add WARN_ON() when deleting rports" Date: Tue, 12 Mar 2019 10:08:33 -0700 Message-Id: <20190312170359.167317611@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170347.868927101@linuxfoundation.org> References: <20190312170347.868927101@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit d8f6382a7d026989029e2e50c515df954488459b ] This reverts commit bbc0f8bd88abefb0f27998f40a073634a3a2db89. It added a warning whose intent was to check whether the rport was still linked into the peer list. It doesn't work as intended and gives false positive warnings for two reasons: 1) If the rport is never linked into the peer list it will not be considered empty since the list_head is never initialized. 2) If the rport is deleted from the peer list using list_del_rcu(), then the list_head is in an undefined state and it is not considered empty. Signed-off-by: Ross Lagerwall Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/libfc/fc_rport.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 1e1c0f1b9e69..8ed2113f5a1e 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -184,7 +184,6 @@ void fc_rport_destroy(struct kref *kref) struct fc_rport_priv *rdata; rdata = container_of(kref, struct fc_rport_priv, kref); - WARN_ON(!list_empty(&rdata->peers)); kfree_rcu(rdata, rcu); } EXPORT_SYMBOL(fc_rport_destroy); -- 2.19.1