From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B846C43381 for ; Thu, 14 Mar 2019 12:14:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECF8A21855 for ; Thu, 14 Mar 2019 12:14:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="illF9kj0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727377AbfCNMOE (ORCPT ); Thu, 14 Mar 2019 08:14:04 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35662 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727362AbfCNMOE (ORCPT ); Thu, 14 Mar 2019 08:14:04 -0400 Received: by mail-wr1-f65.google.com with SMTP id t18so5599559wrx.2 for ; Thu, 14 Mar 2019 05:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g4s2vP608w4BYUINt5jyN6fBpaCQmtHIKqgtJ2QnaYs=; b=illF9kj060sqJoiNYMswilE87JJDs+PvBZ3nrqths2RoslF3jGNSz43Y4ssHdboAIf qsN/k9K4ycDqGhCUhXgt9FoTHvRbMlY2LqFjXVOMCDrKwHpkljCdUafyHiseOUM+dypx qxOsbpbp5pKAQuH8DzGL2IGGUCAUOo2U2WtnhfJLY6M2G/civGzR2XFjTXolC8+Jfldg iv3WHexr6rDpNG3aRP4PuxIQlox9AjD0YtLKw+kLVoNIFZGG0DEFaY6dAdaTs6z8gwN6 UKYb4PUpYE6/sxCTsj+Av24ms3yWtOfy3iroPISPBF8RoAmEfQOFdXjFIR+0XkffdCJo RKXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g4s2vP608w4BYUINt5jyN6fBpaCQmtHIKqgtJ2QnaYs=; b=N8r8HxF8EBqrqCF38ExgNL7VATBHVkd1shQ+x/cvOvHLIsUXgMUXWyG2pXhhDstH7l XmDTz6keX9CeOz0u5FyCOBooQ9oNA5qwvtJGQ1Xs9CiKtL3alJOaEh97M/taUH/98am7 KmtDCfKQSf6w6m5UVA2VVfi8URnezeIgfKXVic6nOuBz2lLy7WLslioqEUYqccsKCrng xUyC75CjLFMVfeHHL1krFIB4ZvGIiJoaePGXDWFDxcvHjY1dVL8r8cyd2SNKy/lP7YBU 8G94jaqAQNS4LDKrjSYYZlCTRPSa+xWpwkRFdteO5VJBxpfdJUgZ6SXQpsDN7UNEnpB3 MSJA== X-Gm-Message-State: APjAAAUl7VlZEHlzd8OLdWxmP0PMiI9KJUU8KqdlvBQrYc0ukyaORN/O SUngBv/hm2nAl2k8zHjxacW7DQ== X-Google-Smtp-Source: APXvYqzbjiD94W0rTCssqWmTdNO2mjrka2R81YjZ/7tRO3GAyqiNORpeYT8n9VIN/Ij3xjRpKt+1cw== X-Received: by 2002:adf:f548:: with SMTP id j8mr21424874wrp.321.1552565641920; Thu, 14 Mar 2019 05:14:01 -0700 (PDT) Received: from apalos (ppp-94-64-206-130.home.otenet.gr. [94.64.206.130]) by smtp.gmail.com with ESMTPSA id v4sm2886851wmg.1.2019.03.14.05.13.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Mar 2019 05:14:01 -0700 (PDT) Date: Thu, 14 Mar 2019 14:13:58 +0200 From: Ilias Apalodimas To: Gregory CLEMENT Cc: "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, Christian Neubert , Vincent Guittot , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Maxime Chevallier , stable@vger.kernel.org Subject: Re: [PATCH 1/2] cpufreq: armada-37xx: fix clock parenting Message-ID: <20190314121358.GA19385@apalos> References: <20190308164710.10597-1-gregory.clement@bootlin.com> <20190308164710.10597-2-gregory.clement@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190308164710.10597-2-gregory.clement@bootlin.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Christian, Gregory, > From: Christian Neubert > > The clock parenting was not setup properly when DVFS was enabled. It was > expected that the same clock source was used with and without DVFS which > was not the case. > > This patch fixes this issue, allowing to make the cpufreq support work > when the CPU clock source are not the default ones. > > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") > Cc: > [gregory: extract from a larger patch, modify comments and commit log] > Signed-off-by: Christian Neubert > Signed-off-by: Gregory CLEMENT > --- > drivers/cpufreq/armada-37xx-cpufreq.c | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c > index 75491fc841a6..ad4463e4266e 100644 > --- a/drivers/cpufreq/armada-37xx-cpufreq.c > +++ b/drivers/cpufreq/armada-37xx-cpufreq.c > @@ -162,11 +162,25 @@ static void __init armada37xx_cpufreq_dvfs_setup(struct regmap *base, > } > > /* > - * Set cpu clock source, for all the level we keep the same > - * clock source that the one already configured. For this one > - * we need to use the clock framework > + * Set CPU clock source, for all the level we keep the same > + * clock source that the one already configured with DVS > + * disabled. For this one we need to use the clock framework > */ > parent = clk_get_parent(clk); > + > + /* > + * Unset parent clock to force the clock framework setting again > + * the clock parent > + */ > + clk_set_parent(clk, NULL); > + > + /* > + * For the Armada 37xx CPU clocks, setting the parent will > + * actually configure the parent when DVFS is enabled. At > + * hardware level it will be a different register from the one > + * read when doing clk_get_parent that will be set with > + * clk_set_parent. > + */ > clk_set_parent(clk, parent); > } > > -- > 2.20.1 > I applied this and selected only CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y CONFIG_CPU_FREQ_GOV_PERFORMANCE=y CONFIG_CPU_FREQ_GOV_POWERSAVE=y The board boots up with 'powersave' instead of 'performance' (maybe some init script?) When i tried changing to 'performance' i got this: [ 164.134589] Internal error: synchronous parity or ECC error: 96000018 [#1] PREEMPT SMP [ 164.139899] Modules linked in: mvneta mvmdio phylink crct10dif_ce ip_tables x_tables ipv6 [ 164.148321] CPU: 1 PID: 2485 Comm: bash Not tainted 5.0.0espressobin+ #68 [ 164.155305] Hardware name: Globalscale Marvell ESPRESSOBin Board (DT) [ 164.161938] pstate: 000003c5 (nzcv DAIF -PAN -UAO) [ 164.166873] pc : do_mem_abort+0x48/0xb0 [ 164.170808] lr : el1_da+0x20/0x88 [ 164.174210] sp : ffff000011b5b1f0 [ 164.177614] x29: ffff000011b5b1f0 x28: ffff80003a0ab800 [ 164.183080] x27: 0000000000000000 x26: 0000000000000000 [ 164.188545] x25: 0000000000000000 x24: 0000000000000025 [ 164.194012] x23: 00000000000003c5 x22: ffff000010c37318 [ 164.199477] x21: ffff000010c371f0 x20: ffff000011b5b220 [ 164.204942] x19: 000000009600004f x18: 0000000000000000 [ 164.210408] x17: 0000000000000000 x16: 0000000000000005 [ 164.215873] x15: 0000000000000000 x14: 0000000000000000 [ 164.221339] x13: ffff80003ac55168 x12: ffff80003ac55168 [ 164.226805] x11: 0000000000000026 x10: 0101010101010101 [ 164.232270] x9 : 0000000000000000 x8 : 0000000000000000 [ 164.237735] x7 : 0000000000000000 x6 : 0000000000000000 [ 164.243201] x5 : 0000000000000000 x4 : 0000000000000000 [ 164.248667] x3 : 0000000000000000 x2 : 0000000000000000 [ 164.254133] x1 : 0000000000000000 x0 : 0000000000000000 [ 164.259601] Process bash (pid: 2485, stack limit = 0x00000000eb09c765) [ 164.266318] Call trace: [ 164.268830] do_mem_abort+0x48/0xb0 [ 164.272413] el1_da+0x20/0x88 [ 164.275460] el1_error+0x14/0xe4 [ 164.278778] Code: 2a1303e1 9ba07c63 aa1603e0 8b030095 (f8636883) [ 164.285053] ---[ end trace 78a878c96fcb4581 ]--- [ 164.289795] Kernel panic - not syncing: Fatal exception [ 164.295171] SMP: stopping secondary CPUs [ 164.299211] Kernel Offset: disabled [ 164.302788] CPU features: 0x002,2000200c [ 164.306817] Memory Limit: none [ 164.309961] ---[ end Kernel panic - not syncing: Fatal exception ]--- Cheers /Ilias