From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55A6C43381 for ; Thu, 14 Mar 2019 23:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A45962184C for ; Thu, 14 Mar 2019 23:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="GEMihuLJ"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="bSxg03iY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727701AbfCNXZO (ORCPT ); Thu, 14 Mar 2019 19:25:14 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:51531 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727412AbfCNXZO (ORCPT ); Thu, 14 Mar 2019 19:25:14 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 81D6621CF1; Thu, 14 Mar 2019 19:25:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 14 Mar 2019 19:25:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=hdcYMimbl9jt3BtQbZkdiu7nSAu /QAaNUSPOgO28E9g=; b=GEMihuLJc+Kmvfvia1xmg9AH3PH6GXNqY6AV6JXzm8U ADqjl6thPfFBdNbzw1cacECIrHKe0b5sa8SVsuDubT6ySwPi+AFwplXyFOVfduc3 XaUu/iVybUFVm1XxfjkIM1AWd2sIfQxDrldV6Nj5+8vJHopI4zEdYgWjoAQY705E ulIXNJfRPc4NMIoXKVQccmsLTQfag62YQ0CGUbyaJK4O2E88oFYc3EKXe/7CYrJz gLJ88LMi0+1hqZBKocp9GaCzvASmX92OkInL+qB1Kt2xJ6HPijG3KR7oYgSXZd6L 7QXcDfk7WYnPcqXP3Pogt1FV9CPiLs8sYh0kXbOyp+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hdcYMi mbl9jt3BtQbZkdiu7nSAu/QAaNUSPOgO28E9g=; b=bSxg03iYukC7wNiBSVlLwP ROAfoli2SbsBj8kWbz3WceVgoCAiaqs8XRH8QOcGZpx0tfBnTEDIUt8N7cdeUY3e vbmGIPDK4lb9nWQJ2SBtPBuhmXNFXvbVzSF/1eKeBMwqubNuEps4yPBf3Je/cOjX 1ud3cwRrk9dNzdQPAmlHduTGGyewqkigkFCWfGHDKBhI3tg5Y8RJVj69uYaW0VVZ I65AzxFc5HdVHkTxgOjPwuB8Nw80Fh8/edDl5AuCuZJM2M+8MjIzBwY7pND2/J9R 0mjs0Xc25CWGok2sX9B0NSFbT7z5EcrkCxJEawYyNWK7iA0+Xmr7lg05/QgZ8PzA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrheefgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecukfhppeduvddrvdejrdeihedrvddvudenucfrrghrrghmpehmrghilhhfrhho mhepghhrvghgsehkrhhorghhrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [12.27.65.221]) by mail.messagingengine.com (Postfix) with ESMTPA id 5E8D110311; Thu, 14 Mar 2019 19:25:12 -0400 (EDT) Date: Thu, 14 Mar 2019 16:25:11 -0700 From: Greg KH To: Jeff Kirsher Cc: Pat Riehecky , stable@vger.kernel.org, Raanan Avargil , Aaron Brown Subject: Re: f3ed935de e1000e: Initial support for KabeLake Message-ID: <20190314232511.GA2167@kroah.com> References: <16ecaae0-5552-2c86-1a3a-7012266984a7@fnal.gov> <20190314200829.GB16125@kroah.com> <49292bc4792d9d32f7812ebc7e343802c21bec86.camel@intel.com> <20190314215449.GC17893@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Mar 14, 2019 at 03:53:29PM -0700, Jeff Kirsher wrote: > On Thu, 2019-03-14 at 14:54 -0700, Greg KH wrote: > > On Thu, Mar 14, 2019 at 02:17:34PM -0700, Jeff Kirsher wrote: > > > On Thu, 2019-03-14 at 13:08 -0700, Greg KH wrote: > > > > On Thu, Mar 14, 2019 at 02:34:17PM -0500, Pat Riehecky wrote: > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9cd34b3a1 > > > > > > > > > > The additional hardware support would be helpful in the 4.4 > > > > > long > > > > > term tree. > > > > > > > > > > e1000e: Initial support for KabeLake > > > > > i219 (4) and i219 (5) are the next LOM generations that will be > > > > > available on the next Intel platform (KabeLake). > > > > > This patch provides the initial support for the devices. > > > > > > > > > > Signed-off-by: Raanan Avargil > > > > > Tested-by: Aaron Brown > > > > > Signed-off-by: Jeff Kirsher > > > > > > > > Does this patch work properly on 4.4.y for this hardware with > > > > just > > > > this > > > > patch? > > > > > > > > Also, always cc: the authors of the patch when asking for them to > > > > be > > > > added to stable, to get their opinion/objection if needed. > > > > > > I am fine with commit 9cd34b3a1 "e1000e: Initial support for > > > KabeLake" > > > being backported. It is just the addition a device ids. > > > > Great, thanks! > > > > But, the patch does not apply to 4.4.y at all. Pat, can you make up > > a > > backport that I can apply and send it to us? > > I see that you do not have this commit on the 4.4.y tree: > > f3ed935de059 e1000e: initial support for i219-LM (3) > > Which is causing the issues that Greg is seeing. This commit is not a > "simple" add new device id type of patch. This commit would be a hard > requirement for the other commit to be applied. > > I am fine with both being applied, but this second commit adds code for > properly accessing the NVM for e1000_pch_spt devices (which all the > i219 devices are). Yeah, that's not worth it. Just use 4.9, or really 4.14, or even more realistic, 4.19 instead. Especially for any system that might be using this type of network card, you should NOT be using 4.4 or 4.9 there at the moment anyway. thanks, greg k-h