From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F22C43381 for ; Thu, 21 Mar 2019 05:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFBE0218AE for ; Thu, 21 Mar 2019 05:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553146046; bh=VDWy8FvksGR8KiiV4VeyBDzeddK1G2N9GavYYT2mho4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PNrxAiRSchjmO0mMayJ6rq41Q98U7fk7LAMt1FPn98Ngab0Tcuz5x0Mu6PFVBHIZ0 orT2W0dYRpOrgPodmy4piBQ6rfh8avDfneLfIlIPGv+daAdJWNjdX7pAKlAJ/WTtN3 ev1TcsGLWRs3q6P24/1Y5lKdEVKvECI/u1TdVBmY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726005AbfCUF10 (ORCPT ); Thu, 21 Mar 2019 01:27:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:48428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbfCUF10 (ORCPT ); Thu, 21 Mar 2019 01:27:26 -0400 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16FE52184E; Thu, 21 Mar 2019 05:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553146045; bh=VDWy8FvksGR8KiiV4VeyBDzeddK1G2N9GavYYT2mho4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p4ADs1uyrZMHe0JDk0Fq+CLBRPHbe3opTnibVp59kwqb7KbraQvQ96GDIGB9qpndV JxjNIaWoVdaqIcGW6wbPtpnRHrYWoCZnu4zWrBaQiufCig+fr0ZbpHoLXXdYvthQ4k 6Qfo068KZfImThn3mwpn2muyKM42v+qSusDhLc6o= Date: Thu, 21 Mar 2019 06:27:22 +0100 From: Greg Kroah-Hartman To: Sasha Levin Cc: Samuel Holland , Eric Biggers , stable@vger.kernel.org Subject: Re: Build error in 4.14 stable-queue Message-ID: <20190321052722.GB21413@kroah.com> References: <20190320222726.GA698@sol.localdomain> <20190321002844.GD25262@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190321002844.GD25262@sasha-vm> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 20, 2019 at 08:28:44PM -0400, Sasha Levin wrote: > On Wed, Mar 20, 2019 at 06:50:00PM -0500, Samuel Holland wrote: > > On 03/20/19 17:27, Eric Biggers wrote: > > > queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch > > > causes a build error: > > > > > > CC drivers/clocksource/arm_arch_timer.o > > > drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'? > > > .read_cntpct_el0 = sun50i_a64_read_cntpct_el0, > > > ^~~~~~~~~~~~~~~ > > > read_cntvct_el0 > > > make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1 > > > make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2 > > > > 4.14 looks to be before the kernel switched to using CNTPCT internally, so that > > hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0 > > still needs to be there for the .read_cntp_tval_el0 implementation.) > > > > Apologies for the breakage, > > Samuel > > I've dropped it from 4.14, thanks all! I don't see it dropped in the public tree, so I've dropped it for real now :) thanks, greg k-h