From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C714C43381 for ; Thu, 21 Mar 2019 21:27:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D3F4218A5 for ; Thu, 21 Mar 2019 21:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726692AbfCUV1w (ORCPT ); Thu, 21 Mar 2019 17:27:52 -0400 Received: from mail.bugwerft.de ([46.23.86.59]:52202 "EHLO mail.bugwerft.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726555AbfCUV1w (ORCPT ); Thu, 21 Mar 2019 17:27:52 -0400 X-Greylist: delayed 447 seconds by postgrey-1.27 at vger.kernel.org; Thu, 21 Mar 2019 17:27:51 EDT Received: from localhost.localdomain (pD95EF74E.dip0.t-ipconnect.de [217.94.247.78]) by mail.bugwerft.de (Postfix) with ESMTPSA id 8DE10381860; Thu, 21 Mar 2019 21:19:07 +0000 (UTC) From: Daniel Mack To: boris.brezillon@collabora.com Cc: haojian.zhuang@gmail.com, robert.jarzmik@free.fr, miquel.raynal@bootlin.com, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Daniel Mack , stable@vger.kernel.org Subject: [PATCH] mtd: rawnand: marvell: select target before setting up data interface Date: Thu, 21 Mar 2019 22:20:10 +0100 Message-Id: <20190321212010.3995-1-daniel@zonque.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Now that the nand drivers are responsible for selecting the target prior to hardware access, a call to marvell_nfc_select_target() is necessary from marvell_nfc_setup_data_interface(). This is a regression introduced by commit b25251414f6e ("mtd: rawnand: marvell: Stop implementing ->select_chip()"). Fixes: b25251414f6e ("mtd: rawnand: marvell: Stop implementing ->select_chip()") Cc: Boris Brezillon Cc: Signed-off-by: Daniel Mack --- drivers/mtd/nand/raw/marvell_nand.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index 84283c6bb0ff..93abe5be8995 100644 --- a/drivers/mtd/nand/raw/marvell_nand.c +++ b/drivers/mtd/nand/raw/marvell_nand.c @@ -2325,6 +2325,8 @@ static int marvell_nfc_setup_data_interface(struct nand_chip *chip, int chipnr, struct marvell_nfc_timings nfc_tmg; int read_delay; + marvell_nfc_select_target(chip, chip->cur_cs); + sdr = nand_get_sdr_timings(conf); if (IS_ERR(sdr)) return PTR_ERR(sdr); -- 2.20.1