From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6601BC43381 for ; Fri, 22 Mar 2019 08:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CFD52083D for ; Fri, 22 Mar 2019 08:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727585AbfCVIav convert rfc822-to-8bit (ORCPT ); Fri, 22 Mar 2019 04:30:51 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:45423 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbfCVIav (ORCPT ); Fri, 22 Mar 2019 04:30:51 -0400 Received: from xps13 (aaubervilliers-681-1-92-153.w90-88.abo.wanadoo.fr [90.88.33.153]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 9D859100006; Fri, 22 Mar 2019 08:30:48 +0000 (UTC) Date: Fri, 22 Mar 2019 09:30:46 +0100 From: Miquel Raynal To: Daniel Mack Cc: boris.brezillon@collabora.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Richard Weinberger Subject: Re: [PATCH] mtd: rawnand: marvell: select target before setting up data interface Message-ID: <20190322093046.71df010d@xps13> In-Reply-To: <20190321212010.3995-1-daniel@zonque.org> References: <20190321212010.3995-1-daniel@zonque.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Daniel, + Richard: this is fixes materials Daniel Mack wrote on Thu, 21 Mar 2019 22:20:10 +0100: > Now that the nand drivers are responsible for selecting the target > prior to hardware access, a call to marvell_nfc_select_target() is > necessary from marvell_nfc_setup_data_interface(). > > This is a regression introduced by commit b25251414f6e ("mtd: > rawnand: marvell: Stop implementing ->select_chip()"). > > Fixes: b25251414f6e ("mtd: rawnand: marvell: Stop implementing ->select_chip()") > Cc: Boris Brezillon > Cc: > Signed-off-by: Daniel Mack > --- > drivers/mtd/nand/raw/marvell_nand.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c > index 84283c6bb0ff..93abe5be8995 100644 > --- a/drivers/mtd/nand/raw/marvell_nand.c > +++ b/drivers/mtd/nand/raw/marvell_nand.c > @@ -2325,6 +2325,8 @@ static int marvell_nfc_setup_data_interface(struct nand_chip *chip, int chipnr, > struct marvell_nfc_timings nfc_tmg; > int read_delay; > > + marvell_nfc_select_target(chip, chip->cur_cs); > + > sdr = nand_get_sdr_timings(conf); > if (IS_ERR(sdr)) > return PTR_ERR(sdr); I had a short look yesterday and this is very likely to be the root cause of the regression, thank you very much! Acked-by: Miquel Raynal Thanks, Miquèl