From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0DDC43381 for ; Fri, 22 Mar 2019 09:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57E62218E2 for ; Fri, 22 Mar 2019 09:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727680AbfCVJFT convert rfc822-to-8bit (ORCPT ); Fri, 22 Mar 2019 05:05:19 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:53340 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727665AbfCVJFT (ORCPT ); Fri, 22 Mar 2019 05:05:19 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id B539327D974; Fri, 22 Mar 2019 09:05:17 +0000 (GMT) Date: Fri, 22 Mar 2019 10:05:14 +0100 From: Boris Brezillon To: Miquel Raynal Cc: Daniel Mack , haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Richard Weinberger Subject: Re: [PATCH] mtd: rawnand: marvell: select target before setting up data interface Message-ID: <20190322100514.25c3f9ee@collabora.com> In-Reply-To: <20190322093046.71df010d@xps13> References: <20190321212010.3995-1-daniel@zonque.org> <20190322093046.71df010d@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, 22 Mar 2019 09:30:46 +0100 Miquel Raynal wrote: > Hi Daniel, > > + Richard: this is fixes materials > > Daniel Mack wrote on Thu, 21 Mar 2019 22:20:10 > +0100: > > > Now that the nand drivers are responsible for selecting the target > > prior to hardware access, a call to marvell_nfc_select_target() is > > necessary from marvell_nfc_setup_data_interface(). > > > > This is a regression introduced by commit b25251414f6e ("mtd: > > rawnand: marvell: Stop implementing ->select_chip()"). > > > > Fixes: b25251414f6e ("mtd: rawnand: marvell: Stop implementing ->select_chip()") > > Cc: Boris Brezillon > > Cc: > > Signed-off-by: Daniel Mack > > --- > > drivers/mtd/nand/raw/marvell_nand.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c > > index 84283c6bb0ff..93abe5be8995 100644 > > --- a/drivers/mtd/nand/raw/marvell_nand.c > > +++ b/drivers/mtd/nand/raw/marvell_nand.c > > @@ -2325,6 +2325,8 @@ static int marvell_nfc_setup_data_interface(struct nand_chip *chip, int chipnr, > > struct marvell_nfc_timings nfc_tmg; > > int read_delay; > > > > + marvell_nfc_select_target(chip, chip->cur_cs); Maybe s/chip->cur_cs/chipnr/ > > + > > sdr = nand_get_sdr_timings(conf); > > if (IS_ERR(sdr)) > > return PTR_ERR(sdr); > > I had a short look yesterday and this is very likely to be the root > cause of the regression, thank you very much! > > Acked-by: Miquel Raynal > > > Thanks, > Miquèl