From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C873FC43381 for ; Fri, 22 Mar 2019 11:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95C48218A2 for ; Fri, 22 Mar 2019 11:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253623; bh=bTIwpOOPUe5LpbjB2zaho4Q3rT8Nop7//JIb/GRkSlk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OzOIPm+14BZfz23YNVosHGdB9/stK/9zk8Soc7yaUM0TJSCTCo+zcfY+2hRVKS3sU 5pGm8YfgWSZdGu8aNgGFr1Ws3oQwxv9BfTJa55H9lip6XWRJST5u3SMxNJnjRm4+ny 4iuwDo4KGB3GZArXbVkmuU20dSoVw24sqNfkR8AQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728326AbfCVLUW (ORCPT ); Fri, 22 Mar 2019 07:20:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:46720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728236AbfCVLUW (ORCPT ); Fri, 22 Mar 2019 07:20:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DCCB218A2; Fri, 22 Mar 2019 11:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253621; bh=bTIwpOOPUe5LpbjB2zaho4Q3rT8Nop7//JIb/GRkSlk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QK6PvA4J9zjrJxZq4aSy1BG1jYPVfMTEEcOgeLtlCPZV6L1o74t8J8BE+8ECYszs2 fY/ZlzLrSj+lTI2SczW5KeeAZV30/+9B+VmUKG+PgKynbOPBULYk5zgN2s6CuhwKrR szXp6/vR7vMBVmiyRNItbIF4uy0irfmnO64RV0eg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nathan Chancellor , Lee Jones , Sasha Levin Subject: [PATCH 3.18 005/134] mfd: twl-core: Fix section annotations on {,un}protect_pm_master Date: Fri, 22 Mar 2019 12:13:38 +0100 Message-Id: <20190322111210.675947624@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 8838555089f0345b87f4277fe5a8dd647dc65589 ] When building the kernel with Clang, the following section mismatch warning appears: WARNING: vmlinux.o(.text+0x3d84a3b): Section mismatch in reference from the function twl_probe() to the function .init.text:unprotect_pm_master() The function twl_probe() references the function __init unprotect_pm_master(). This is often because twl_probe lacks a __init annotation or the annotation of unprotect_pm_master is wrong. Remove the __init annotation on the *protect_pm_master functions so there is no more mismatch. Signed-off-by: Nathan Chancellor Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/twl-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index db11b4f406116..2608c1d865857 100644 --- a/drivers/mfd/twl-core.c +++ b/drivers/mfd/twl-core.c @@ -983,7 +983,7 @@ add_children(struct twl4030_platform_data *pdata, unsigned irq_base, * letting it generate the right frequencies for USB, MADC, and * other purposes. */ -static inline int __init protect_pm_master(void) +static inline int protect_pm_master(void) { int e = 0; @@ -992,7 +992,7 @@ static inline int __init protect_pm_master(void) return e; } -static inline int __init unprotect_pm_master(void) +static inline int unprotect_pm_master(void) { int e = 0; -- 2.19.1