From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9249CC10F03 for ; Fri, 22 Mar 2019 11:20:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59F88218A2 for ; Fri, 22 Mar 2019 11:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253631; bh=W/zAZItphTK6xwyTX3Rq8ezjf79qTQHew8biQsbiNEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ux2zc+BvHr/HhT1Wtx2HKAT+msGwTfB1r5w7o2qD2fx6hkUCy9ltlfSmglvphpdEn ATDkMYcqUzYQFKOdGb/DtVlJcLW+cSV44rOFkks/9xyILi8anddXInTN8YTeLLd3f/ AEq/CE5ccwZVorwtPS+WhcM1AYpE8/IgLqUcHZ1E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728373AbfCVLUa (ORCPT ); Fri, 22 Mar 2019 07:20:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:46812 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728363AbfCVLU2 (ORCPT ); Fri, 22 Mar 2019 07:20:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AF890218A2; Fri, 22 Mar 2019 11:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253628; bh=W/zAZItphTK6xwyTX3Rq8ezjf79qTQHew8biQsbiNEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wl+jQwUS4GK/ySiK0ljMjerVqJB9V2MvjwS3Ggq7eEPe8LFxkLkOc5mCaEIcsnRwb 3M+eEw65Uf6DfPKWfxh3NhjDgkEXvmM2NFqpqvmKHd7lyIeSMg0jtzinW9hijMgVSa ezbUf6cT+gp59uMWoQsYjMET5YLfbtkdeOhl49V8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Linus Walleij , Lee Jones , Sasha Levin Subject: [PATCH 3.18 007/134] mfd: ab8500-core: Return zero in get_register_interruptible() Date: Fri, 22 Mar 2019 12:13:40 +0100 Message-Id: <20190322111210.743329126@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 10628e3ecf544fa2e4e24f8e112d95c37884dc98 ] This function is supposed to return zero on success or negative error codes on error. Unfortunately, there is a bug so it sometimes returns non-zero, positive numbers on success. I noticed this bug during review and I can't test it. It does appear that the return is sometimes propogated back to _regmap_read() where all non-zero returns are treated as failure so this may affect run time. Fixes: 47c1697508f2 ("mfd: Align ab8500 with the abx500 interface") Signed-off-by: Dan Carpenter Reviewed-by: Linus Walleij Signed-off-by: Lee Jones Signed-off-by: Sasha Levin --- drivers/mfd/ab8500-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c index bde2fc0724103..44ebb84c2e747 100644 --- a/drivers/mfd/ab8500-core.c +++ b/drivers/mfd/ab8500-core.c @@ -259,7 +259,7 @@ static int get_register_interruptible(struct ab8500 *ab8500, u8 bank, mutex_unlock(&ab8500->lock); dev_vdbg(ab8500->dev, "rd: addr %#x => data %#x\n", addr, ret); - return ret; + return (ret < 0) ? ret : 0; } static int ab8500_get_register(struct device *dev, u8 bank, -- 2.19.1