From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F174C43381 for ; Fri, 22 Mar 2019 11:20:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F332C2192D for ; Fri, 22 Mar 2019 11:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253657; bh=5em/hWVJj8a/ps1CgDWg89vBP224+tMO7uguVUMSDQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VCPVZp3BdTVP7upvzmwmahS+c5xa1sVeiADYNju+Ng2yT3N4eUoCE7gWl1d+mUtku ZVgJeQbRRMwDIAifx4BLfFPnDS6K4ELPvlmZ0K4M6lIdaBygUOjOkupvJHTotgQ42Q O8+Gx0ujV5dIoZd812ZnOOdy9I8NacVebPybV6Zw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbfCVLU4 (ORCPT ); Fri, 22 Mar 2019 07:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:47332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727957AbfCVLUz (ORCPT ); Fri, 22 Mar 2019 07:20:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2CBB21917; Fri, 22 Mar 2019 11:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253655; bh=5em/hWVJj8a/ps1CgDWg89vBP224+tMO7uguVUMSDQE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IQxFQkOLi6zfIEvrsJ1jwpFA7LsMZ1JCTiZ8ARJYMhP3He4kvjR6H76QX4Jy7ukd+ tRQpSwn8qG2rfEBcshDbrjI7m7/phsL+NlKXvZeORarvVFv5ls3/V/stliqWv6nA5i E4gbk1e8kL6g0gBeO6J/eQnJSsvcrqiHjfsSygeY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Felipe Balbi , Sasha Levin Subject: [PATCH 3.18 031/134] usb: gadget: Potential NULL dereference on allocation error Date: Fri, 22 Mar 2019 12:14:04 +0100 Message-Id: <20190322111212.005243655@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit df28169e1538e4a8bcd8b779b043e5aa6524545c ] The source_sink_alloc_func() function is supposed to return error pointers on error. The function is called from usb_get_function() which doesn't check for NULL returns so it would result in an Oops. Of course, in the current kernel, small allocations always succeed so this doesn't affect runtime. Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/gadget/function/f_sourcesink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_sourcesink.c b/drivers/usb/gadget/function/f_sourcesink.c index 45b41d1cfd19d..ecfd9e71a0d50 100644 --- a/drivers/usb/gadget/function/f_sourcesink.c +++ b/drivers/usb/gadget/function/f_sourcesink.c @@ -1149,7 +1149,7 @@ static struct usb_function *source_sink_alloc_func( ss = kzalloc(sizeof(*ss), GFP_KERNEL); if (!ss) - return NULL; + return ERR_PTR(-ENOMEM); ss_opts = container_of(fi, struct f_ss_opts, func_inst); -- 2.19.1