From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79418C43381 for ; Fri, 22 Mar 2019 13:18:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EA9F21873 for ; Fri, 22 Mar 2019 13:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553260690; bh=pnBHd4x5gX3yWnr24gNiR3cV6grV2bx4EBgFrbjyim8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YWnKfvQCGFKSKbLtbh01fipW1ebboe8p1eiMW7zQmdXFWddzK2yPxw0P2EvMcT6Jd 9OC+E8hzes7xPgA/nodxdR9rKJia/RhxC29iSurm1sUsqfVYiuN5Oyns+6KZr0EXHN rlmaUsbsG+OO/lGzF2yJ6ev+GgJ1dENFpNsnvR7w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729095AbfCVLYS (ORCPT ); Fri, 22 Mar 2019 07:24:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:51378 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729091AbfCVLYS (ORCPT ); Fri, 22 Mar 2019 07:24:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 341442190A; Fri, 22 Mar 2019 11:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253857; bh=pnBHd4x5gX3yWnr24gNiR3cV6grV2bx4EBgFrbjyim8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VsfcZQReW2Cwy6Ltmm7h1ThLt7WwlB/WzvQ7qzka+c/cu3FSd3lxr+Gh2kUqvYMR4 qvyKo/RwM+/iquTi3sZJ8uTqX8wiHuS/JSYY0m0qUX65EeL2yStCwPQKa/0wD+kU8H STQBvPb0AJQMx75pAhDOG1VeWtvcvcr7MmBy40JI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Konrad Rzeszutek Wilk Subject: [PATCH 3.18 078/134] iscsi_ibft: Fix missing break in switch statement Date: Fri, 22 Mar 2019 12:14:51 +0100 Message-Id: <20190322111215.747552622@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gustavo A. R. Silva commit df997abeebadaa4824271009e2d2b526a70a11cb upstream. Add missing break statement in order to prevent the code from falling through to case ISCSI_BOOT_TGT_NAME, which is unnecessary. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: b33a84a38477 ("ibft: convert iscsi_ibft module to iscsi boot lib") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/iscsi_ibft.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -503,6 +503,7 @@ static umode_t __init ibft_check_tgt_for case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_CHAP_TYPE: rc = S_IRUGO; + break; case ISCSI_BOOT_TGT_NAME: if (tgt->tgt_name_len) rc = S_IRUGO;