From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3E1C43381 for ; Fri, 22 Mar 2019 11:31:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DE442183E for ; Fri, 22 Mar 2019 11:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553254297; bh=hbTjLCI2mYtMwMdjNK5FKPOvsEzmNL2FGJAFw4d8oIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=r0HYEKjc4fWS1TwenfHKcUMCEsi3D8FK24vTtTrgMi+sxFkB3jlD/CK8piLCQKveU YrCYoEJBNysn8YFFEn7/coM8daKXFZdsyeRFe99iDE9/ooA9yGXeuvpfm1g3eQTfPd Dlk2tRK+PD4k7OMLp3vDisbPBDhZDm2mJucDTx04= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730052AbfCVLbg (ORCPT ); Fri, 22 Mar 2019 07:31:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:59790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730047AbfCVLbf (ORCPT ); Fri, 22 Mar 2019 07:31:35 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DB10218B0; Fri, 22 Mar 2019 11:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553254294; bh=hbTjLCI2mYtMwMdjNK5FKPOvsEzmNL2FGJAFw4d8oIU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BzYatSAxhQm/Iy87JUf+fysApHhvd8w7HSqxz5vTOalSbxC4bo+PIVhIuiFD156u6 +UNSVlmwi4kmYGmAVPkde4ZRZuQWUSiO82DyNHnIgPxC5q5bfyExc/AeUBfHcxTraa tkHn2lkuJ5s0x2UyARKGqAaI2hSLVfkPl6W6NeNM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yonglong Liu , Peng Li , "David S. Miller" , Sasha Levin Subject: [PATCH 4.4 091/230] net: hns: Fix wrong read accesses via Clause 45 MDIO protocol Date: Fri, 22 Mar 2019 12:13:49 +0100 Message-Id: <20190322111243.004266025@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111236.796964179@linuxfoundation.org> References: <20190322111236.796964179@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit cec8abba13e6a26729dfed41019720068eeeff2b ] When reading phy registers via Clause 45 MDIO protocol, after write address operation, the driver use another write address operation, so can not read the right value of any phy registers. This patch fixes it. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c index 37491c85bc42..6ff13c559e52 100644 --- a/drivers/net/ethernet/hisilicon/hns_mdio.c +++ b/drivers/net/ethernet/hisilicon/hns_mdio.c @@ -319,7 +319,7 @@ static int hns_mdio_read(struct mii_bus *bus, int phy_id, int regnum) } hns_mdio_cmd_write(mdio_dev, is_c45, - MDIO_C45_WRITE_ADDR, phy_id, devad); + MDIO_C45_READ, phy_id, devad); } /* Step 5: waitting for MDIO_COMMAND_REG 's mdio_start==0,*/ -- 2.19.1