From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5255BC4360F for ; Fri, 22 Mar 2019 12:55:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16DB121873 for ; Fri, 22 Mar 2019 12:55:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553259326; bh=NaHbdABmOy4WLU1jSuJX9KsJAbYf7iionQJL5zPJIIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fkhotpKv2UsmaOLG1pnWsWl6Cy7ApoOXjMisbjfFdvrwt+xjCQYPhjdT9HNEAfNxH 5vhsZVQYAuWf1ueSfJpOTkoDgg764NccpqJNcYJSseAcixxNZybu5WfSjB8ejI4p9j 0c8LaeNJGJvV0L0h23m8j2oJyLhccPCwtCHwueC8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728700AbfCVMzZ (ORCPT ); Fri, 22 Mar 2019 08:55:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:53784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732177AbfCVLuD (ORCPT ); Fri, 22 Mar 2019 07:50:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B91C20693; Fri, 22 Mar 2019 11:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553255402; bh=NaHbdABmOy4WLU1jSuJX9KsJAbYf7iionQJL5zPJIIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MDp986XmRaXrQiyZ+3yjDrpcznCnErgYGScBN7OypqmuZta+4ll0otO16qrKw2VAW sgScTEEDtABYAo8NZma5WtMTpDgad9cC6Z+ujW89gPvAW29AvpFSYMmN2D26y9/NSc SEAkqwHVqTqPHmsboLfS8rpHoN6mvZ3+5OA1XI84= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Jiong Wang , Daniel Borkmann , Sasha Levin Subject: [PATCH 4.14 062/183] nfp: bpf: fix code-gen bug on BPF_ALU | BPF_XOR | BPF_K Date: Fri, 22 Mar 2019 12:14:50 +0100 Message-Id: <20190322111246.212048004@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111241.819468003@linuxfoundation.org> References: <20190322111241.819468003@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 71c190249f0ced5b26377ea6bf829ab3af77a40c ] The intended optimization should be A ^ 0 = A, not A ^ -1 = A. Fixes: cd7df56ed3e6 ("nfp: add BPF to NFP code translator") Reviewed-by: Jakub Kicinski Signed-off-by: Jiong Wang Signed-off-by: Daniel Borkmann Signed-off-by: Sasha Levin --- drivers/net/ethernet/netronome/nfp/bpf/jit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c b/drivers/net/ethernet/netronome/nfp/bpf/jit.c index 239dfbe8a0a1..3105ee5bbf8e 100644 --- a/drivers/net/ethernet/netronome/nfp/bpf/jit.c +++ b/drivers/net/ethernet/netronome/nfp/bpf/jit.c @@ -1017,7 +1017,7 @@ static int xor_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) static int xor_imm(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) { - return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !~meta->insn.imm); + return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !meta->insn.imm); } static int and_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta) -- 2.19.1