From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4527C43381 for ; Fri, 22 Mar 2019 12:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75B08218FC for ; Fri, 22 Mar 2019 12:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553259081; bh=7LHtZuqu85NpoF/nHGoyPux7KbkpbXfDds2LHEOX5pA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=2TSDsb1+ZfvkKkc+s5V2b9nWfCnL9JiTBhablh0387Z10c2S+0qH62LgXz9gmg871 xy6q8ZrhyvFBiHFufkfdu+tiNWvhK217XVAITIrf9Iuch2lOOztIHhYRWDGjfWzLo7 hBXrzHJv7h+0x7SXAoGGWtjn8oom9hMGGjhmul/M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733194AbfCVLyd (ORCPT ); Fri, 22 Mar 2019 07:54:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:59070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733189AbfCVLyc (ORCPT ); Fri, 22 Mar 2019 07:54:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46A1120850; Fri, 22 Mar 2019 11:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553255671; bh=7LHtZuqu85NpoF/nHGoyPux7KbkpbXfDds2LHEOX5pA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CMh/INki5P4nsGpVR4m5D8OGV/5zojzD7sixARzAhWcWzvRiEoF1owGncre6hk+hl K38LM3XN/+e+IIkTMZmpcGX8DrjZQoSL4n1iEh4ncmVyhw2yOxi2hmpeLJ9QUM4tAY /uOXfrtvekmGKjbI1w0Z4G4RP/Q3qh8UIXls0X7o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Adrian Hunter , Jiri Olsa , Arnaldo Carvalho de Melo Subject: [PATCH 4.14 163/183] perf intel-pt: Fix CYC timestamp calculation after OVF Date: Fri, 22 Mar 2019 12:16:31 +0100 Message-Id: <20190322111253.719142364@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111241.819468003@linuxfoundation.org> References: <20190322111241.819468003@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Adrian Hunter commit 03997612904866abe7cdcc992784ef65cb3a4b81 upstream. CYC packet timestamp calculation depends upon CBR which was being cleared upon overflow (OVF). That can cause errors due to failing to synchronize with sideband events. Even if a CBR change has been lost, the old CBR is still a better estimate than zero. So remove the clearing of CBR. Signed-off-by: Adrian Hunter Cc: Jiri Olsa Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/20190206103947.15750-4-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/util/intel-pt-decoder/intel-pt-decoder.c | 1 - 1 file changed, 1 deletion(-) --- a/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c +++ b/tools/perf/util/intel-pt-decoder/intel-pt-decoder.c @@ -1389,7 +1389,6 @@ static int intel_pt_overflow(struct inte { intel_pt_log("ERROR: Buffer overflow\n"); intel_pt_clear_tx_flags(decoder); - decoder->cbr = 0; decoder->timestamp_insn_cnt = 0; decoder->pkt_state = INTEL_PT_STATE_ERR_RESYNC; decoder->overflow = true;