From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C15EC4360F for ; Fri, 22 Mar 2019 12:35:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C452A2070D for ; Fri, 22 Mar 2019 12:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553258152; bh=S47NSWzpzWBygLdfIQbBL5muhP+weMDCZtgmVTXy71U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EdecQQUVaoPQNulGq5Zr/Puqn2QSgl1YxtffiBEKqvMpyUAIeJVCXwDvJ8neA4jTV 7uL34E7y+LpuiL/ga5jXHp9AjvlbhKWQAhaR6pM/aYSEqCt0ssm6FCBgmstSvGI5rd XdHc4nDth9gs57Q0QsydEVQjuvYYq+XQtyy9rzB0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389205AbfCVMLv (ORCPT ); Fri, 22 Mar 2019 08:11:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:50004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389553AbfCVMLq (ORCPT ); Fri, 22 Mar 2019 08:11:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ACD9A2083D; Fri, 22 Mar 2019 12:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256706; bh=S47NSWzpzWBygLdfIQbBL5muhP+weMDCZtgmVTXy71U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ip3/eKccI9/2L7o9OmTsKyuq69kBe9dIMvYko2IVeJ+4ksyXgO122aTEEjDBX/PKO UuWphRlRpo3DXDhU10rCYpgETpILFZAxKFTxeKmpr/rkVupX2ABdrSX268+qFydHlE dNd7Mu1BG7l4rB1bLqk4djsNx981+Vg6uzJaFZ9Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Gustavo A. R. Silva" , Herbert Xu Subject: [PATCH 5.0 013/238] crypto: ccree - fix missing break in switch statement Date: Fri, 22 Mar 2019 12:13:52 +0100 Message-Id: <20190322111259.012590292@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111258.383569278@linuxfoundation.org> References: <20190322111258.383569278@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gustavo A. R. Silva commit b5be853181a8d4a6e20f2073ccd273d6280cad88 upstream. Add missing break statement in order to prevent the code from falling through to case S_DIN_to_DES. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: 63ee04c8b491 ("crypto: ccree - add skcipher support") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/ccree/cc_cipher.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/crypto/ccree/cc_cipher.c +++ b/drivers/crypto/ccree/cc_cipher.c @@ -80,6 +80,7 @@ static int validate_keys_sizes(struct cc default: break; } + break; case S_DIN_to_DES: if (size == DES3_EDE_KEY_SIZE || size == DES_KEY_SIZE) return 0;