From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D180C43381 for ; Fri, 22 Mar 2019 12:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42E4421900 for ; Fri, 22 Mar 2019 12:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553258312; bh=4GdY35UyizSYrAWL9+E1FqQOUY9I+nTX80PT0Nc7ric=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YIjKmcI5nTMoKquj9CRonftpg8lddaXtYYHLXc60VtDi9MZkWu1dV1pMOJkAvjKvX 4tkIZGJ7Druqw/3L3Ht59szL5pQuTkHZew7n7COczaEO6+Ue/uN17qlnNzf9hei7t2 E1v727TLhsOSUOJpPCRY6UPmDVRmLAqpmXXLSIxE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389024AbfCVMJK (ORCPT ); Fri, 22 Mar 2019 08:09:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:47580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389252AbfCVMJJ (ORCPT ); Fri, 22 Mar 2019 08:09:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C007B20685; Fri, 22 Mar 2019 12:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553256549; bh=4GdY35UyizSYrAWL9+E1FqQOUY9I+nTX80PT0Nc7ric=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BZKQZZdB2kD8WNoM0NFXXqBgZv7NQQr6Y1MZKGu7PoU/S6abzB3scaPsMLtoTKKIT EJ64t1IDSzKoaqpy2IYGSsNt5rmBYlfXIVxAv0LIP5/su/tbxgixe02eVOVZEu6OV5 mY6zxbgvYeJR7wxGv/pAAqk6n98YHfKFC/9DcVVE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joseph Qi , Yihao Wu , "J. Bruce Fields" Subject: [PATCH 4.19 245/280] nfsd: fix wrong check in write_v4_end_grace() Date: Fri, 22 Mar 2019 12:16:38 +0100 Message-Id: <20190322111340.267107303@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111306.356185024@linuxfoundation.org> References: <20190322111306.356185024@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yihao Wu commit dd838821f0a29781b185cd8fb8e48d5c177bd838 upstream. Commit 62a063b8e7d1 "nfsd4: fix crash on writing v4_end_grace before nfsd startup" is trying to fix a NULL dereference issue, but it mistakenly checks if the nfsd server is started. So fix it. Fixes: 62a063b8e7d1 "nfsd4: fix crash on writing v4_end_grace before nfsd startup" Cc: stable@vger.kernel.org Reviewed-by: Joseph Qi Signed-off-by: Yihao Wu Signed-off-by: J. Bruce Fields Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfsctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -1126,7 +1126,7 @@ static ssize_t write_v4_end_grace(struct case 'Y': case 'y': case '1': - if (nn->nfsd_serv) + if (!nn->nfsd_serv) return -EBUSY; nfsd4_end_grace(nn); break;