From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0585BC43381 for ; Mon, 25 Mar 2019 09:09:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0E7F20879 for ; Mon, 25 Mar 2019 09:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730029AbfCYJJO convert rfc822-to-8bit (ORCPT ); Mon, 25 Mar 2019 05:09:14 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:47167 "EHLO relay11.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726234AbfCYJJO (ORCPT ); Mon, 25 Mar 2019 05:09:14 -0400 Received: from xps13 (aaubervilliers-681-1-92-153.w90-88.abo.wanadoo.fr [90.88.33.153]) (Authenticated sender: miquel.raynal@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id F1A80100022; Mon, 25 Mar 2019 09:09:10 +0000 (UTC) Date: Mon, 25 Mar 2019 10:09:09 +0100 From: Miquel Raynal To: Daniel Mack Cc: boris.brezillon@collabora.com, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org, Richard Weinberger Subject: Re: [PATCH] mtd: rawnand: marvell: select target before setting up data interface Message-ID: <20190325100909.5f3558b9@xps13> In-Reply-To: <6bcd6f18-6e57-2221-9e32-5bbabfffc48d@zonque.org> References: <20190321212010.3995-1-daniel@zonque.org> <20190322093046.71df010d@xps13> <6bcd6f18-6e57-2221-9e32-5bbabfffc48d@zonque.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Daniel, Daniel Mack wrote on Fri, 22 Mar 2019 19:48:08 +0100: > Hi Miquel, > > On 22/3/2019 9:30 AM, Miquel Raynal wrote: > > + Richard: this is fixes materials > > > > Daniel Mack wrote on Thu, 21 Mar 2019 22:20:10 > > +0100: > > > >> Now that the nand drivers are responsible for selecting the target > >> prior to hardware access, a call to marvell_nfc_select_target() is > >> necessary from marvell_nfc_setup_data_interface(). > >> > >> This is a regression introduced by commit b25251414f6e ("mtd: > >> rawnand: marvell: Stop implementing ->select_chip()"). > >> > >> Fixes: b25251414f6e ("mtd: rawnand: marvell: Stop implementing ->select_chip()") > >> Cc: Boris Brezillon > >> Cc: > >> Signed-off-by: Daniel Mack > >> --- > >> drivers/mtd/nand/raw/marvell_nand.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c > >> index 84283c6bb0ff..93abe5be8995 100644 > >> --- a/drivers/mtd/nand/raw/marvell_nand.c > >> +++ b/drivers/mtd/nand/raw/marvell_nand.c > >> @@ -2325,6 +2325,8 @@ static int marvell_nfc_setup_data_interface(struct nand_chip *chip, int chipnr, > >> struct marvell_nfc_timings nfc_tmg; > >> int read_delay; > >> > >> + marvell_nfc_select_target(chip, chip->cur_cs); > >> + > >> sdr = nand_get_sdr_timings(conf); > >> if (IS_ERR(sdr)) > >> return PTR_ERR(sdr); > > > > I had a short look yesterday and this is very likely to be the root > > cause of the regression, thank you very much! > > Yes it is, it fixes the regression I have reported. > > Do you want me to resend with that nit addressed you mentioned? My > version works well, I know that much :) Yes please, resent with Boris' comment addressed and we'll be fine. Thanks, Miquèl