From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=iZEs=R4=vger.kernel.org=stable-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 73960C43381
	for <stable@archiver.kernel.org>; Mon, 25 Mar 2019 10:52:41 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 47BBA2085A
	for <stable@archiver.kernel.org>; Mon, 25 Mar 2019 10:52:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730606AbfCYKwk (ORCPT <rfc822;stable@archiver.kernel.org>);
        Mon, 25 Mar 2019 06:52:40 -0400
Received: from verein.lst.de ([213.95.11.211]:57787 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729727AbfCYKwk (ORCPT <rfc822;stable@vger.kernel.org>);
        Mon, 25 Mar 2019 06:52:40 -0400
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 5D86668C7B; Mon, 25 Mar 2019 11:52:31 +0100 (CET)
Date:   Mon, 25 Mar 2019 11:52:31 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
        Yi Zhang <yi.zhang@redhat.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme: target: fix nvmet_file_init_bvec()
Message-ID: <20190325105231.GA24907@lst.de>
References: <20190325100708.24172-1-ming.lei@redhat.com> <20190325100708.24172-2-ming.lei@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190325100708.24172-2-ming.lei@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: stable-owner@vger.kernel.org
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

On Mon, Mar 25, 2019 at 06:07:07PM +0800, Ming Lei wrote:
> There isn't sg iterator helper for building bvec, so invent one
> and fix the issue in nvmet_file_init_bvec().
> 
> The issue is that one sg may include multipge continuous pages, and
> only the 1st .bv_offset isn't zero, also the length for the last bvec
> has to consider the remained length.

The scatterlist in the nvme target is always allocated by the nvmet
code itself an thus never contains multi-page sg list entries.