From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E9AC43381 for ; Tue, 26 Mar 2019 07:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25E5E2070B for ; Tue, 26 Mar 2019 07:36:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731008AbfCZHgc (ORCPT ); Tue, 26 Mar 2019 03:36:32 -0400 Received: from verein.lst.de ([213.95.11.211]:34714 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726413AbfCZHgb (ORCPT ); Tue, 26 Mar 2019 03:36:31 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 1D6A568C4E; Tue, 26 Mar 2019 08:36:23 +0100 (CET) Date: Tue, 26 Mar 2019 08:36:22 +0100 From: Christoph Hellwig To: Ming Lei Cc: linux-nvme@lists.infradead.org, Christoph Hellwig , Yi Zhang , Sagi Grimberg , Chaitanya Kulkarni , stable@vger.kernel.org Subject: Re: [PATCH 1/4] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Message-ID: <20190326073622.GA21617@lst.de> References: <20190326031928.9499-1-ming.lei@redhat.com> <20190326031928.9499-2-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190326031928.9499-2-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Note that in many cases allocating larger pages in the other targets would be useful. Given that you fix the one places where we made a page size assumption I don't see a great need to limit outselves here.