From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF27C43381 for ; Wed, 27 Mar 2019 08:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F5072075D for ; Wed, 27 Mar 2019 08:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725768AbfC0IP6 (ORCPT ); Wed, 27 Mar 2019 04:15:58 -0400 Received: from verein.lst.de ([213.95.11.211]:40414 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfC0IP5 (ORCPT ); Wed, 27 Mar 2019 04:15:57 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 9DCCE68B05; Wed, 27 Mar 2019 09:15:49 +0100 (CET) Date: Wed, 27 Mar 2019 09:15:49 +0100 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Ming Lei , Yi Zhang , Sagi Grimberg , Chaitanya Kulkarni , stable , linux-nvme Subject: Re: [PATCH 2/4] nvmet: fix computation of io vector number Message-ID: <20190327081549.GF20525@lst.de> References: <20190326031928.9499-1-ming.lei@redhat.com> <20190326031928.9499-3-ming.lei@redhat.com> <20190326073800.GB21617@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Mar 26, 2019 at 03:50:01PM +0800, Ming Lei wrote: > On Tue, Mar 26, 2019 at 3:38 PM Christoph Hellwig wrote: > > > > I'd rather see this merged with the last one (and patch 3 dropped as > > it just gets removed entirely in 4) - that fixes all the issues together > > and doesn't require your patch 1 as as a workaround first. > > Patch 1 isn't a workaround, which is needed for stable tree, and > the other fixes won't work without patch 1. > > However, we may revert patch 1 for 5.1 in which multi-page bvec > is supported. Lets do it another way around - put the proper fix into 5.1-rc and only apply patch 1 for stable. No need to put something in and immediately revert it.