From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB39C43381 for ; Thu, 28 Mar 2019 23:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9574A2173C for ; Thu, 28 Mar 2019 23:18:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbfC1XSS (ORCPT ); Thu, 28 Mar 2019 19:18:18 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:58176 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728028AbfC1XSS (ORCPT ); Thu, 28 Mar 2019 19:18:18 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 61F0314D644F7; Thu, 28 Mar 2019 16:18:17 -0700 (PDT) Date: Thu, 28 Mar 2019 16:18:14 -0700 (PDT) Message-Id: <20190328.161814.1978203886746383455.davem@davemloft.net> To: gregkh@linuxfoundation.org Cc: stable@vger.kernel.org Subject: Re: [PATCHES] Networking From: David Miller In-Reply-To: <20190328215149.GA21581@kroah.com> References: <20190328.122407.1125989210145347163.davem@davemloft.net> <20190328205525.GA566@kroah.com> <20190328215149.GA21581@kroah.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Mar 2019 16:18:17 -0700 (PDT) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Greg KH Date: Thu, 28 Mar 2019 22:51:49 +0100 > On Thu, Mar 28, 2019 at 09:55:25PM +0100, Greg KH wrote: >> On Thu, Mar 28, 2019 at 12:24:07PM -0700, David Miller wrote: >> > >> > Please queue up the following networking bug fixes for v4.19 and v5.0 >> > -stable, respectively. >> >> Now queued up, thanks. > > Hm, looks like the tun patch needs a call to rcu_read_unlock() in the > error path. Should I drop that patch for now until a fix hits Linus's > tree, or just leave it as-is for now and take the fix later? Hmmm, I thought I included the: >From 9180bb4f046064dfa4541488102703b402bb04e1 Mon Sep 17 00:00:00 2001 From: Eric Dumazet Date: Sat, 16 Mar 2019 13:09:53 -0700 Subject: [PATCH] tun: add a missing rcu_read_unlock() in error path [ Upstream commit 9180bb4f046064dfa4541488102703b402bb04e1 ] In my latest patch I missed one rcu_read_unlock(), in case device is down. Fixes: 4477138fa0ae ("tun: properly test for IFF_UP") Signed-off-by: Eric Dumazet Reported-by: syzbot Signed-off-by: David S. Miller --- drivers/net/tun.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 0d343359f647..e9ca1c088d0b 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1960,6 +1960,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile, rcu_read_lock(); if (unlikely(!(tun->dev->flags & IFF_UP))) { err = -EIO; + rcu_read_unlock(); goto drop; } -- 2.20.1