From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54CBDC43381 for ; Thu, 28 Mar 2019 08:26:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C7BD2054F for ; Thu, 28 Mar 2019 08:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553761618; bh=yhbefFAskoKajWtWo4NJvONGCnMo4w6PZNUVvkMnApQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=c2jFIW1P1spEvgyJS/T3CVBw/ssM8sdh76UHlYRJJ6t4CzJGhe46Z+aCvqa0btWTT Pl4zaC+/xrsu+ylF0t543BvxVP0+7qkhmQtgLYU24kYKwv53oEpxz9hTbdVWsBvCnV UN4JbcG4uaPnxE6xLnDs1F7IA01lnigG2Ss2Fcxg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726094AbfC1I05 (ORCPT ); Thu, 28 Mar 2019 04:26:57 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:42168 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbfC1I04 (ORCPT ); Thu, 28 Mar 2019 04:26:56 -0400 Received: by mail-lf1-f67.google.com with SMTP id b7so8784202lfg.9; Thu, 28 Mar 2019 01:26:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Dy9r15OZE6oqDGLJfiOw2HIx8bfxlYCUyTBApxLbIrE=; b=JTuMwuvvu3FzAouXkblQodq4DNHDOgDE87bO2As2McjUJiYqWsN6wtA/VHCXVQMgsg +14xWJBAhpUEua6G0j/w2Wlto4VSKcX+B+63AUpMMVYIw20hdBOzom1amg+7mSs3cYwm +Mqt04WjNq78toSx1sLQ5830pBCohsESRoaTkhyP76xP4AgJwRJMjTrM7VfFyiKqI/MW 7GU+kDoTKXQCSt5g03gIp2Ox0jtkgQMYNzaJtXKSuc6cJ889CS+XH0GGRAZw+hfZZMK6 KAwPePf7b96ZRKhAA5/LA/UTKxhgEnmWFLA/arXOhcuC5BFHtMf9HiLml+q18QHcDEWQ MR4A== X-Gm-Message-State: APjAAAXe3dAB66Et7COmSUnYn9v5IgRo6AhG1ihR7VJCuiN2o14tkRE8 pvs1yo+b5LgvtUZRrXsUy2+GmV50 X-Google-Smtp-Source: APXvYqwWwXHcbplLDRr8iKwgN/2XQo656BQooYLaTCyGblR/wkms2/HMF0YdpUmfut9Tz/Hdfj3SKw== X-Received: by 2002:a19:ee11:: with SMTP id g17mr20580622lfb.117.1553761614622; Thu, 28 Mar 2019 01:26:54 -0700 (PDT) Received: from xi.terra (c-74bee655.07-184-6d6c6d4.bbcust.telenor.se. [85.230.190.116]) by smtp.gmail.com with ESMTPSA id 15sm4930342lft.88.2019.03.28.01.26.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 01:26:53 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.91) (envelope-from ) id 1h9QNG-0006ga-Ld; Thu, 28 Mar 2019 09:26:58 +0100 Date: Thu, 28 Mar 2019 09:26:58 +0100 From: Johan Hovold To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Johan Hovold , linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] USB: serial: option: add Olicard 600 Message-ID: <20190328082658.GB5567@localhost> References: <20190327142532.27869-1-bjorn@mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190327142532.27869-1-bjorn@mork.no> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 27, 2019 at 03:25:32PM +0100, Bjørn Mork wrote: > This is a Qualcomm based device with a QMI function on interface 4. > It is mode switched from 2020:2030 using a standard eject message. > > T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 6 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=2020 ProdID=2031 Rev= 2.32 > S: Manufacturer=Mobile Connect > S: Product=Mobile Connect > S: SerialNumber=0123456789ABCDEF > C:* #Ifs= 6 Cfg#= 1 Atr=80 MxPwr=500mA > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > E: Ad=83(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=82(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > E: Ad=85(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > E: Ad=87(I) Atr=03(Int.) MxPS= 10 Ivl=32ms > E: Ad=86(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > E: Ad=89(I) Atr=03(Int.) MxPS= 8 Ivl=32ms > E: Ad=88(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms > I:* If#= 5 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=(none) > E: Ad=8a(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us > > Cc: stable@vger.kernel.org > Signed-off-by: Bjørn Mork > --- > drivers/usb/serial/option.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > index 11b21d9410f3..02ee5b707de2 100644 > --- a/drivers/usb/serial/option.c > +++ b/drivers/usb/serial/option.c > @@ -1943,6 +1943,8 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e01, 0xff, 0xff, 0xff) }, /* D-Link DWM-152/C1 */ > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x3e02, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/C1 */ > { USB_DEVICE_AND_INTERFACE_INFO(0x07d1, 0x7e11, 0xff, 0xff, 0xff) }, /* D-Link DWM-156/A3 */ > + { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x2031, 0xff), /* Olicard 600 */ > + .driver_info = RSVD(4) }, > { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) }, /* OLICARD300 - MT6225 */ I fixed up the surrounding lines with their odd comment alignment as well. Now applied. Thanks, Johan