stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Changbin Du <changbin.du@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.19 35/52] perf tests: Fix a memory leak of cpu_map object in the openat_syscall_event_on_all_cpus test
Date: Fri, 29 Mar 2019 20:52:42 -0400	[thread overview]
Message-ID: <20190330005301.26868-35-sashal@kernel.org> (raw)
In-Reply-To: <20190330005301.26868-1-sashal@kernel.org>

From: Changbin Du <changbin.du@gmail.com>

[ Upstream commit 93faa52e8371f0291ee1ff4994edae2b336b6233 ]

  =================================================================
  ==7497==ERROR: LeakSanitizer: detected memory leaks

  Direct leak of 40 byte(s) in 1 object(s) allocated from:
      #0 0x7f0333a88f30 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xedf30)
      #1 0x5625e5326213 in cpu_map__trim_new util/cpumap.c:45
      #2 0x5625e5326703 in cpu_map__read util/cpumap.c:103
      #3 0x5625e53267ef in cpu_map__read_all_cpu_map util/cpumap.c:120
      #4 0x5625e5326915 in cpu_map__new util/cpumap.c:135
      #5 0x5625e517b355 in test__openat_syscall_event_on_all_cpus tests/openat-syscall-all-cpus.c:36
      #6 0x5625e51528e6 in run_test tests/builtin-test.c:358
      #7 0x5625e5152baf in test_and_print tests/builtin-test.c:388
      #8 0x5625e51543fe in __cmd_test tests/builtin-test.c:583
      #9 0x5625e515572f in cmd_test tests/builtin-test.c:722
      #10 0x5625e51c3fb8 in run_builtin /home/changbin/work/linux/tools/perf/perf.c:302
      #11 0x5625e51c44f7 in handle_internal_command /home/changbin/work/linux/tools/perf/perf.c:354
      #12 0x5625e51c48fb in run_argv /home/changbin/work/linux/tools/perf/perf.c:398
      #13 0x5625e51c5069 in main /home/changbin/work/linux/tools/perf/perf.c:520
      #14 0x7f033214d09a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2409a)

Signed-off-by: Changbin Du <changbin.du@gmail.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Fixes: f30a79b012e5 ("perf tools: Add reference counting for cpu_map object")
Link: http://lkml.kernel.org/r/20190316080556.3075-15-changbin.du@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 tools/perf/tests/openat-syscall-all-cpus.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/tests/openat-syscall-all-cpus.c b/tools/perf/tests/openat-syscall-all-cpus.c
index c531e6deb104..493ecb611540 100644
--- a/tools/perf/tests/openat-syscall-all-cpus.c
+++ b/tools/perf/tests/openat-syscall-all-cpus.c
@@ -45,7 +45,7 @@ int test__openat_syscall_event_on_all_cpus(struct test *test __maybe_unused, int
 	if (IS_ERR(evsel)) {
 		tracing_path__strerror_open_tp(errno, errbuf, sizeof(errbuf), "syscalls", "sys_enter_openat");
 		pr_debug("%s\n", errbuf);
-		goto out_thread_map_delete;
+		goto out_cpu_map_delete;
 	}
 
 	if (perf_evsel__open(evsel, cpus, threads) < 0) {
@@ -119,6 +119,8 @@ int test__openat_syscall_event_on_all_cpus(struct test *test __maybe_unused, int
 	perf_evsel__close_fd(evsel);
 out_evsel_delete:
 	perf_evsel__delete(evsel);
+out_cpu_map_delete:
+	cpu_map__put(cpus);
 out_thread_map_delete:
 	thread_map__put(threads);
 	return err;
-- 
2.19.1


  parent reply	other threads:[~2019-03-30  1:05 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30  0:52 [PATCH AUTOSEL 4.19 01/52] ARC: u-boot args: check that magic number is correct Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 02/52] arc: hsdk_defconfig: Enable CONFIG_BLK_DEV_RAM Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 03/52] inotify: Fix fsnotify_mark refcount leak in inotify_update_existing_watch() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 04/52] perf/core: Restore mmap record type correctly Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 05/52] perf data: Don't store auxtrace index for directory data file Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 06/52] ext4: avoid panic during forced reboot Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 07/52] ext4: add missing brelse() in add_new_gdb_meta_bg() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 08/52] ext4: report real fs size after failed resize Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 09/52] ALSA: echoaudio: add a check for ioremap_nocache Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 10/52] ALSA: sb8: add a check for request_region Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 11/52] auxdisplay: hd44780: Fix memory leak on ->remove() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 12/52] drm/udl: use drm_gem_object_put_unlocked Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 13/52] IB/mlx4: Fix race condition between catas error reset and aliasguid flows Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 14/52] i40iw: Avoid panic when handling the inetdev event Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 15/52] mmc: davinci: remove extraneous __init annotation Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 16/52] ALSA: opl3: fix mismatch between snd_opl3_drum_switch definition and declaration Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 17/52] thermal/intel_powerclamp: fix __percpu declaration of worker_data Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 18/52] thermal: samsung: Fix incorrect check after code merge Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 19/52] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 20/52] thermal/int340x_thermal: Add additional UUIDs Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 21/52] thermal/int340x_thermal: fix mode setting Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 22/52] thermal/intel_powerclamp: fix truncated kthread name Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 23/52] scsi: iscsi: flush running unbind operations when removing a session Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 24/52] sched/cpufreq: Fix 32-bit math overflow Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 25/52] sched/core: Fix buffer overflow in cgroup2 property cpu.max Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 26/52] x86/mm: Don't leak kernel addresses Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 27/52] tools/power turbostat: return the exit status of a command Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 28/52] perf list: Don't forget to drop the reference to the allocated thread_map Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 29/52] perf config: Fix an error in the config template documentation Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 30/52] perf config: Fix a memory leak in collect_config() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 31/52] perf build-id: Fix memory leak in print_sdt_events() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 32/52] perf top: Fix error handling in cmd_top() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 33/52] perf hist: Add missing map__put() in error case Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 34/52] perf evsel: Free evsel->counts in perf_evsel__exit() Sasha Levin
2019-03-30  0:52 ` Sasha Levin [this message]
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 36/52] perf tests: Fix memory leak by expr__find_other() in test__expr() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 37/52] perf tests: Fix a memory leak in test__perf_evsel__tp_sched_test() Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 38/52] ACPI / utils: Drop reference in test for device presence Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 39/52] PM / Domains: Avoid a potential deadlock Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 40/52] blk-iolatency: #include "blk.h" Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 41/52] drm/exynos/mixer: fix MIXER shadow registry synchronisation code Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 42/52] irqchip/stm32: Don't clear rising/falling config registers at init Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 43/52] irqchip/mbigen: Don't clear eventid when freeing an MSI Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 44/52] x86/hpet: Prevent potential NULL pointer dereference Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 45/52] x86/hyperv: " Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 46/52] x86/cpu/cyrix: Use correct macros for Cyrix calls on Geode processors Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 47/52] drm/nouveau/debugfs: Fix check of pm_runtime_get_sync failure Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 48/52] iommu/vt-d: Check capability before disabling protected memory Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 49/52] x86/hw_breakpoints: Make default case in hw_breakpoint_arch_parse() return an error Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 50/52] fix incorrect error code mapping for OBJECTID_NOT_FOUND Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 51/52] x86/gart: Exclude GART aperture from kcore Sasha Levin
2019-03-30  0:52 ` [PATCH AUTOSEL 4.19 52/52] ext4: prohibit fstrim in norecovery mode Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190330005301.26868-35-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=acme@redhat.com \
    --cc=ast@kernel.org \
    --cc=changbin.du@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).