From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4304FC43381 for ; Sat, 30 Mar 2019 01:05:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A1C0218AC for ; Sat, 30 Mar 2019 01:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553907929; bh=BRU6nGgdquvegwE9j9bghspsqA8Zse4qqoTXwFZzOXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=b4ns4zHVeyCVPM8Ps+E2OzRnzHW1XTcx9yMZlrWCcU/X6T0Ijlo/oGso5q3r8ouOF a5Dh64VSIFMCy39qbcHuL/iH3JHkrU0/ZS8gARkbZOWlpiUk6SqUScMur2htR+lwbx 9iX9hyL4jpikUtRJrOR4uAPQFhgaj0Mreu05uSxk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731456AbfC3AyP (ORCPT ); Fri, 29 Mar 2019 20:54:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:33100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731471AbfC3AyO (ORCPT ); Fri, 29 Mar 2019 20:54:14 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A633521904; Sat, 30 Mar 2019 00:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553907254; bh=BRU6nGgdquvegwE9j9bghspsqA8Zse4qqoTXwFZzOXc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xkkQy4e1pyox5QPmu8weiJZJJhjRQzS2cD/ZaIkvE4mvEalQWmhlgfEbN5ESwn4Em 5FNjbo+unMxTQ+3jIxkYOWqlv437GJarrXQDiMw1bTQQ8PCMVYjrwuMzFUUkXO+KRc CqECYs9MJ+wKZflYRty70Ma459n3cFEnNaCbvMmw= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , "Rafael J . Wysocki" , Sasha Levin , linux-acpi@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 38/52] ACPI / utils: Drop reference in test for device presence Date: Fri, 29 Mar 2019 20:52:45 -0400 Message-Id: <20190330005301.26868-38-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190330005301.26868-1-sashal@kernel.org> References: <20190330005301.26868-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Andy Shevchenko [ Upstream commit 54e3aca84e571559915998aa6cc05e5ac37c043b ] When commit 8661423eea1a ("ACPI / utils: Add new acpi_dev_present helper") introduced acpi_dev_present(), it missed the fact that bus_find_device() took a reference on the device found by it and the callers of acpi_dev_present() don't drop that reference. Drop the reference on the device in acpi_dev_present(). Fixes: 8661423eea1a ("ACPI / utils: Add new acpi_dev_present helper") Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c index 78db97687f26..c4b06cc075f9 100644 --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c @@ -800,6 +800,7 @@ bool acpi_dev_present(const char *hid, const char *uid, s64 hrv) match.hrv = hrv; dev = bus_find_device(&acpi_bus_type, NULL, &match, acpi_dev_match_cb); + put_device(dev); return !!dev; } EXPORT_SYMBOL(acpi_dev_present); -- 2.19.1