stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Michal Simek <michal.simek@xilinx.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sasha Levin <sashal@kernel.org>,
	linux-serial@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 06/21] serial: uartps: console_setup() can't be placed to init section
Date: Fri, 29 Mar 2019 21:30:57 -0400	[thread overview]
Message-ID: <20190330013112.784-6-sashal@kernel.org> (raw)
In-Reply-To: <20190330013112.784-1-sashal@kernel.org>

From: Michal Simek <michal.simek@xilinx.com>

[ Upstream commit 4bb1ce2350a598502b23088b169e16b43d4bc639 ]

When console device is rebinded, console_setup() is called again.
But marking it as __init means that function will be clear after boot is
complete. If console device is binded again console_setup() is not found
and error "Unable to handle kernel paging request at virtual address"
is reported.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/tty/serial/xilinx_uartps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index ffb474c49f0f..eb61a07fcbbc 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -1261,7 +1261,7 @@ static void cdns_uart_console_write(struct console *co, const char *s,
  *
  * Return: 0 on success, negative errno otherwise.
  */
-static int __init cdns_uart_console_setup(struct console *co, char *options)
+static int cdns_uart_console_setup(struct console *co, char *options)
 {
 	struct uart_port *port = &cdns_uart_port[co->index];
 	int baud = 9600;
-- 
2.19.1


  parent reply	other threads:[~2019-03-30  1:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30  1:30 [PATCH AUTOSEL 4.9 01/21] gpio: pxa: handle corner case of unprobed device Sasha Levin
2019-03-30  1:30 ` [PATCH AUTOSEL 4.9 02/21] rsi: improve kernel thread handling to fix kernel panic Sasha Levin
2019-03-30  1:30 ` [PATCH AUTOSEL 4.9 03/21] 9p: do not trust pdu content for stat item size Sasha Levin
2019-03-30  1:30 ` [PATCH AUTOSEL 4.9 04/21] 9p locks: add mount option for lock retry interval Sasha Levin
2019-03-30  1:30 ` [PATCH AUTOSEL 4.9 05/21] f2fs: fix to do sanity check with current segment number Sasha Levin
2019-03-30  1:30 ` Sasha Levin [this message]
2019-03-30  1:30 ` [PATCH AUTOSEL 4.9 07/21] HID: i2c-hid: override HID descriptors for certain devices Sasha Levin
2019-03-30  1:30 ` [PATCH AUTOSEL 4.9 08/21] ARM: samsung: Limit SAMSUNG_PM_CHECK config option to non-Exynos platforms Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 09/21] ACPI / SBS: Fix GPE storm on recent MacBookPro's Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 10/21] cifs: fallback to older infolevels on findfirst queryinfo retry Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 11/21] kernel: hung_task.c: disable on suspend Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 12/21] crypto: sha256/arm - fix crash bug in Thumb2 build Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 13/21] crypto: sha512/arm " Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 14/21] iommu/dmar: Fix buffer overflow during PCI bus notification Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 15/21] soc/tegra: pmc: Drop locking from tegra_powergate_is_powered() Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 16/21] ext4: prohibit fstrim in norecovery mode Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 17/21] lkdtm: Add tests for NULL pointer dereference Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 18/21] ARM: 8839/1: kprobe: make patch_lock a raw_spinlock_t Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 19/21] appletalk: Fix use-after-free in atalk_proc_exit Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 20/21] lib/div64.c: off by one in shift Sasha Levin
2019-03-30  1:31 ` [PATCH AUTOSEL 4.9 21/21] include/linux/swap.h: use offsetof() instead of custom __swapoffset macro Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190330013112.784-6-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).