From: Greg KH <gregkh@linuxfoundation.org>
To: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
stable@vger.kernel.org
Subject: Re: [BACKPORT v3.18] media: ov6650: Fix sensor possibly not detected on probe
Date: Sat, 30 Mar 2019 06:47:12 +0100 [thread overview]
Message-ID: <20190330054712.GC23655@kroah.com> (raw)
In-Reply-To: <20190329212005.6501-1-jmkrzyszt@gmail.com>
On Fri, Mar 29, 2019 at 10:20:05PM +0100, Janusz Krzysztofik wrote:
> After removal of clock_start() from before soc_camera_init_i2c() in
> soc_camera_probe() by commit 9aea470b399d ("[media] soc-camera: switch
> I2C subdevice drivers to use v4l2-clk") introduced in v3.11, the ov6650
> driver could no longer probe the sensor successfully because its clock
> was no longer turned on in advance. The issue was initially worked
> around by adding that missing clock_start() equivalent to OMAP1 camera
> interface driver - the only user of this sensor - but a propoer fix
> should be rather implemented in the sensor driver code itself.
>
> Fix the issue by inserting a delay between the clock is turned on and
> the sensor I2C registers are read for the first time.
>
> Fixes: 9aea470b399d ("[media] soc-camera: switch I2C subdevice drivers to use v4l2-clk")
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Cc: stable@vger.kernel.org
> ---
> Rebased on 3.18, should apply cleanly on 4.4 and 4.9 as well.
>
> I dropped the comment on the patch being tested on an out of tree
> omap1_camera driver mainly because that driver is still in the tree
> in those kernel versions.
>
> drivers/media/i2c/soc_camera/ov6650.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/i2c/soc_camera/ov6650.c b/drivers/media/i2c/soc_camera/ov6650.c
> index ab01598ec83f..c0e25bf55fb8 100644
> --- a/drivers/media/i2c/soc_camera/ov6650.c
> +++ b/drivers/media/i2c/soc_camera/ov6650.c
> @@ -829,6 +829,8 @@ static int ov6650_video_probe(struct i2c_client *client)
> if (ret < 0)
> return ret;
>
> + msleep(20);
> +
> /*
> * check and show product ID and manufacturer ID
> */
> --
> 2.19.2
>
What is the git commit id of this patch in Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-30 5:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 21:20 [BACKPORT v3.18] media: ov6650: Fix sensor possibly not detected on probe Janusz Krzysztofik
2019-03-30 5:47 ` Greg KH [this message]
2019-03-30 10:34 ` Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190330054712.GC23655@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=jmkrzyszt@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).