From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5566CC43381 for ; Mon, 1 Apr 2019 10:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB4002087F for ; Mon, 1 Apr 2019 10:27:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=de.amadeus.com header.i=@de.amadeus.com header.b="P8oL0Ovq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725895AbfDAK1v (ORCPT ); Mon, 1 Apr 2019 06:27:51 -0400 Received: from mail1.bemta25.messagelabs.com ([195.245.230.67]:9241 "EHLO mail1.bemta25.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbfDAK1v (ORCPT ); Mon, 1 Apr 2019 06:27:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=de.amadeus.com; s=SYM2018Q2; t=1554114468; i=@de.amadeus.com; bh=NBaTagWpjGey73NzWzPj7bg+rkBfeAdeagABTlgBJYQ=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=P8oL0OvqXwSZk/dwOPeEH8sh9lH9P1HEQNBc23bhT7lZnbBMv4LCeOx8IaY2JxRGr iBoNa6ThlFLqaxXWTEk90K1+RHRPT+Fg1MW9IKXrHRodolVVQprAb0KVlEl4GZuXLZ +xcuBonicWKMxSaQBYNy3CzLG3IUVpV0JoVqWL04caQtD0zK8K7h3+RkSmzjSezTpm t8ibzC+oNbGg9Hh03uAIrx/BagNh2qjiMNO7KUnn5SRZl8UMl+6vz5yQQW8BBSx3LF 1VHMCQIUIB48WhFJjU3xQB5kU2LxzSLzOzg7Q1zaCMxkIFo+qh6Fs+cHWgTfO5uK7x seH3pUBvbiIgA== Received: from [46.226.52.201] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-3.bemta.az-b.eu-west-1.aws.symcld.net id 28/7F-11025-4A7E1AC5; Mon, 01 Apr 2019 10:27:48 +0000 Authentication-Results: mx.messagelabs.com; dkim=none (message not signed); dmarc=none header.from=de.amadeus.com X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRWlGSWpSXmKPExsWyWrBZWXfJ84U xBle7uCwWTLvIaLFg4yNGByaPC8euMXl83iQXwBTFmpmXlF+RwJrx/d5MxoKZvBX3D15namA8 ztXFyMkhJLCNUWLChFgIex2jxLzt8V2MHBwsAioSXbucQcJsAl4SixecZwexRQTUJZb9esYOU sIsoCzxfD0LSFhYwEdiy/cbYDavgIHE/Edf2boYuYAmPmGUOLlyEitEQlDi5MwnLBC9mhLrd+ lDmNISy/9xgFQwC8hLNG+dzQxicwr4Sqx9eRhskyjQMa8O1kPcqCvx6N07sBIJASWJh73r2SD sYokZ3T0sExiFZiHZNQth1yyEXbOQ7FrAyLKK0SKpKDM9oyQ3MTNH19DAQNfQ0EjX0NJS19DI QC+xSjdJL7VUtzy1uETXUC+xvFivuDI3OSdFLy+1ZBMjMBZSCo5X7GA835V+iFGSg0lJlPfZp oUxQnxJ+SmVGYnFGfFFpTmpxYcYZTg4lCR4fZ8B5QSLUtNTK9Iyc4BRCZOW4OBREuF98RQozV tckJhbnJkOkTrFqMvxsPXzXGYhlrz8vFQpcV4zkBkCIEUZpXlwI2AJ4hKjrJQwLyMDA4MQT0F qUW5mCar8K0ZxDkYlYd5MkCk8mXklcJteAR3BBHSERel8kCNKEhFSUg2MR28YPTIt2v793qcl R/1uZ208r3aHeUPag5f1ZQsrdY3dQng09oX5iKbEzmv0veXLXHPVw1N0otmuD0InK1K3fjGL7 Wlbk+Xl7q3gYbzPeZ7h6ltJ/CV6dnfnnsqTmnj3uUDirBR9UbUPzhyGq/7Kzb9/6WF4sLsAhz j/1LneK2vnN2TFz52ixFKckWioxVxUnAgAqtoyLgsDAAA= X-Env-Sender: thomas.weissschuh@de.amadeus.com X-Msg-Ref: server-8.tower-289.messagelabs.com!1554114466!3608314!4 X-Originating-IP: [171.17.131.35] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.31.5; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24041 invoked from network); 1 Apr 2019 10:27:48 -0000 Received: from unknown (HELO smtpexch.amadeus.com) (171.17.131.35) by server-8.tower-289.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 1 Apr 2019 10:27:48 -0000 Received: from MUCEXMBXCASP01.iis.amadeus.net (172.19.131.9) by smtpexch.amadeus.com (172.19.134.32) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Apr 2019 10:23:19 +0000 Received: from amadeus.com (172.19.131.245) by MUCEXMBXCASP01.iis.amadeus.net (172.19.131.9) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 1 Apr 2019 10:23:22 +0000 Date: Mon, 1 Apr 2019 12:23:21 +0200 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Ben Hutchings CC: stable Subject: Re: [PATCH 3.16 310/366] vmxnet3: fix checks for dma mapping errors Message-ID: <20190401102321.GB15514@amadeus.com> References: <20190329154756.GA14540@fralrnd0033.fra.amadeus.net> <20190329160144.GB14540@fralrnd0033.fra.amadeus.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [172.19.131.245] X-ClientProxiedBy: MUCEXMBXCASP07.iis.amadeus.net (172.19.131.66) To MUCEXMBXCASP01.iis.amadeus.net (172.19.131.9) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Ben, thanks for the prompt reply. On Fri, Mar 29, 2019 at 11:55:34PM +0000, Ben Hutchings wrote: > On Fri, 2019-03-29 at 17:01 +0100, Thomas Weißschuh wrote: > > Hi Ben, > > > > I forgot you to Cc: on the following mail: > > > > https://lore.kernel.org/stable/20190329154756.GA14540@fralrnd0033.fra.amadeus.net/ > > > > Thomas > > > > On Fri, Mar 29, 2019 at 04:47:58PM +0100, Thomas Weißschuh wrote: > > > > 3.16.60-rc1 review patch. If anyone has any objections, please let me know. > > > > > > Sorry for the late response, this just hit the kernel in Debian Jessie > > > (oldstable) a few days ago. > > > > > > > ------------------ > > > > > > > > From: Alexey Khoroshilov > > > > > > > > commit 5738a09d58d5ad2871f1f9a42bf6a3aa9ece5b3c upstream. > > > > > > > > vmxnet3_drv does not check dma_addr with dma_mapping_error() > > > > after mapping dma memory. The patch adds the checks and > > > > tries to handle failures. > > > > > > We are seeing kernel panics/machine freezes/BUGs with the new 3.16.64 from Debian. > > > I bisected it with the vanilla stable kernel and it boiled down to this commit. > > > VMs of multiple nodes of our vmware cluster are affected. > > > The bug can be triggered in multiple ways, I have seen it when an external > > > network request is served, when installing packages over the network and > > > performing a git clone. > [...] > > I missed the upstream follow-up to this, which was commit 58caf637365f > "Driver: Vmxnet3: Fix regression caused by 5738a09". > > I'm attaching a backport of that. I don't have any VMware installation > to test on; could you do that? This indeed fixes the issue. Thomas