From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD18C43381 for ; Mon, 1 Apr 2019 13:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4CBC20830 for ; Mon, 1 Apr 2019 13:52:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="pR0He562"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="8CbnnDMs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbfDANws (ORCPT ); Mon, 1 Apr 2019 09:52:48 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:35703 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728038AbfDANws (ORCPT ); Mon, 1 Apr 2019 09:52:48 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8553221C8E; Mon, 1 Apr 2019 09:52:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 01 Apr 2019 09:52:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=sDM1H+ATS5vXUqbZRnJMeDju13H dBXGvgxrQxsc6I7c=; b=pR0He562g1sFVZtanOLf5z/qlQG6E4PFUR0dKM+dL4V 1FIINOnOm2Bbphq9d7YZ1cSXjQtKE+MAlH0YZu3U7bg2X+VxqbHTFQ6HF9YBsIh3 9+7u3RT/J9Bn7ZUAcwItnC3fbCcV1vEcn0nTlktqrPJL+E3lsgzxtpL58MrxaAE7 Y9uJ0u/yo9J+/q8T/GJAcJFt2MN8p86Yjq8U6rH4aU39KxSC9C2Dz5JVzZYL/yP8 88WhY611GkU2byo5UHB5QYVskdn9/SQgxRQlv/7NpC407CnN/z2Jd+bRApPPMDUZ f98X5P/QmL1j5dSp2iqe+pK/V/MRC0H9u980dyx+uNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=sDM1H+ ATS5vXUqbZRnJMeDju13HdBXGvgxrQxsc6I7c=; b=8CbnnDMse+ZSmG3oiCNwOZ vDb1oHKcHEvcOLcEBXD8A43ONgpIzNyl9FzGW1TKQk03kA5MwKqXT67E4wsLi/48 Az7sHWtX3gethj5s/b7mGMOw3vDwzoeisbcRxu4PqRYAXJOiuhAugWDHQK066Zbh FZA2EpRa4dtA1J+mT82OvY8OyTAdhkhHsXJ7y08/toCiiPmrs6S320oPMeGRhbxG HlRL4B5sF6+qqB3bIU6ZLD/vcQiKNrFoAwym2uzvNvc2hA4UBKN7qqETGCqzkONi ROWLLdzMoTGD2lPJL5XvNorI0oeCmwWHBo3B5SExoDHm2JQ4g7tytvmBQEeI4vrQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrleeggdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrkeelrddutd ejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomhenucev lhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 9DE371039F; Mon, 1 Apr 2019 09:52:46 -0400 (EDT) Date: Mon, 1 Apr 2019 15:52:44 +0200 From: Greg KH To: Cornelia Huck Cc: stable@vger.kernel.org, farman@linux.ibm.com Subject: Re: [PATCH 4.14-stable backport] vfio: ccw: only free cp on final interrupt Message-ID: <20190401135244.GA23581@kroah.com> References: <20190401131425.9536-1-cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190401131425.9536-1-cohuck@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 01, 2019 at 03:14:25PM +0200, Cornelia Huck wrote: > When we get an interrupt for a channel program, it is not > necessarily the final interrupt; for example, the issuing > guest may request an intermediate interrupt by specifying > the program-controlled-interrupt flag on a ccw. > > We must not switch the state to idle if the interrupt is not > yet final; even more importantly, we must not free the translated > channel program if the interrupt is not yet final, or the host > can crash during cp rewind. > > Fixes: e5f84dbaea59 ("vfio: ccw: return I/O results asynchronously") > Cc: stable@vger.kernel.org # v4.12+ > Reviewed-by: Eric Farman > Signed-off-by: Cornelia Huck > (cherry picked from commit 50b7f1b7236bab08ebbbecf90521e84b068d7a17) > --- > drivers/s390/cio/vfio_ccw_drv.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Now queued up, thanks. greg k-h