From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42550C43381 for ; Mon, 1 Apr 2019 13:55:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 095CA208E4 for ; Mon, 1 Apr 2019 13:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554126918; bh=2iM8xGHfNTQw9t6vl+oIiBtFmcLiXjbDZaJvREEPJuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=tFfDbuIKq+/PFXiV5zqwFvDGnGtEfX6iyobBjWsTP/XJu+kICNjaLD7FkNivI8yjf WY7DtY5LE7gnQWQ1h90Sg2ZsCT3Y7hqb5KgIbdWDEmZRlxLl564izrdv1Kq33usBI1 H0ysgXMU3RNEd6PCp8CFTpXsWXGBpPAtTE2s+zgc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbfDANzR (ORCPT ); Mon, 1 Apr 2019 09:55:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:56136 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbfDANzR (ORCPT ); Mon, 1 Apr 2019 09:55:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3078920840; Mon, 1 Apr 2019 13:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554126916; bh=2iM8xGHfNTQw9t6vl+oIiBtFmcLiXjbDZaJvREEPJuQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vB9W8OqDMEyQB4xfimbblxzwkXVDwupiqEsSC27ExFsnIRssquOrBuEwscU8r5w87 kwwFxRF9EgzP5ckYfIA+R+EsEn1hYOqJtaArlrR2cjEqCulfkAynjIE00JBVlfCy+w nlCiHAG4nhGOKduWWT1w3Ywssui8kRnuiZtkqaOg= Date: Mon, 1 Apr 2019 15:55:09 +0200 From: Greg KH To: Ming Lei Cc: Sasha Levin , linux-nvme@lists.infradead.org, Christoph Hellwig , Yi Zhang , Sagi Grimberg , Chaitanya Kulkarni , stable@vger.kernel.org Subject: Re: [PATCH stable only] nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1 Message-ID: <20190401135509.GC23581@kroah.com> References: <20190327090230.12671-1-ming.lei@redhat.com> <20190327161658.GL25262@sasha-vm> <20190328005505.GB19708@ming.t460p> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190328005505.GB19708@ming.t460p> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Mar 28, 2019 at 08:55:06AM +0800, Ming Lei wrote: > On Wed, Mar 27, 2019 at 12:16:58PM -0400, Sasha Levin wrote: > > On Wed, Mar 27, 2019 at 05:02:30PM +0800, Ming Lei wrote: > > > NVMe target only accepts single-page sg list, either file or block > > > device backed target code follows this assumption. > > > > > > However, loop target is one exception, given the sg list is from > > > the host queue directly. > > > > > > This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 > > > for following NVMe target assumption. > > > > > > Reported-by: Yi Zhang > > > Fixes: 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver") > > > Cc: Yi Zhang > > > Cc: Sagi Grimberg > > > Cc: Chaitanya Kulkarni > > > Cc: > > > Signed-off-by: Ming Lei > > > > Could you provide some background as to why this is -stable only in the > > commit message? > > Multi-page bvec has been merged to linus tree already, so the following > patch simply can fix the current issue without needing to limit the segment > size for nvme-loop: > > http://lists.infradead.org/pipermail/linux-nvme/2019-March/023105.html Can you resend the patch with this needed information in it? Also, I don't understand what you are referring to with that url, why can't we just use that patch? thanks, greg k-h