From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78EB5C43381 for ; Mon, 1 Apr 2019 17:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B54520883 for ; Mon, 1 Apr 2019 17:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554139260; bh=y6TEYN6F5Idi1LiIwJVCXR/ZfHUkgDR/v+zd/hV+X3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YDzJheJb7X1A8wN4NCuIURvCcZxXbCVkwXYo1AsaIuDUFWOHj6XRIcghuEw8IROHH mj5/KHEQW65FDhl2kxtGzEL4o+FymKYOgkEqnzDyM+96Gheb1uE7srkK2phlurfH+0 khzx/4VuIFIAxFnDbmjSvV5sehi0wER8oEGt5bt0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731518AbfDARU7 (ORCPT ); Mon, 1 Apr 2019 13:20:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:49404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731728AbfDARU6 (ORCPT ); Mon, 1 Apr 2019 13:20:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA35E21852; Mon, 1 Apr 2019 17:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554139258; bh=y6TEYN6F5Idi1LiIwJVCXR/ZfHUkgDR/v+zd/hV+X3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ygvqLVeMIrVe4VMtFam4ETInLDk2vfkFzbmx06kVc2T5X0Lp3ja7probo19GAPJ11 cXV5sDsNs5S2h+LrzXPI218k3toIOPiEPDxoln+2llBgXmXW5i6ML2omf3sWjJYX9V V67j8rSUWqyDE7Iva+BkdFT+tr9Dc4WCLM2RVz6I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , syzbot , "David S. Miller" Subject: [PATCH 4.14 023/107] tun: add a missing rcu_read_unlock() in error path Date: Mon, 1 Apr 2019 19:01:38 +0200 Message-Id: <20190401170047.832811108@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170045.246405031@linuxfoundation.org> References: <20190401170045.246405031@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet commit 9180bb4f046064dfa4541488102703b402bb04e1 upstream. In my latest patch I missed one rcu_read_unlock(), in case device is down. Fixes: 4477138fa0ae ("tun: properly test for IFF_UP") Signed-off-by: Eric Dumazet Reported-by: syzbot Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/tun.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1569,6 +1569,7 @@ drop: rcu_read_lock(); if (unlikely(!(tun->dev->flags & IFF_UP))) { err = -EIO; + rcu_read_unlock(); goto drop; }