From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1924C43381 for ; Mon, 1 Apr 2019 17:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72C2E20883 for ; Mon, 1 Apr 2019 17:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554141526; bh=O5tSQfWr6Z4h+jEvQgBiUsdbN+cx0pYnpOIEtd1bWnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=J7jGqLby+5mN/yXjprrhkhbrLT9m8ptiBhSglzN6bf1+nhsHpS5OQ3mYWcxUfK6f2 T1/bxlFgQKl+ym9DmXnyauF+P1tUmvZhCxjG8pIP4j070E6UD6X4O/hLmpwtzw+F/R bg2k1n2WoHs0ZV4Nn9ir/hY62DDt/Pvg+2cd5UJw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731360AbfDARS1 (ORCPT ); Mon, 1 Apr 2019 13:18:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:45708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731121AbfDARS0 (ORCPT ); Mon, 1 Apr 2019 13:18:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A818206C0; Mon, 1 Apr 2019 17:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554139106; bh=O5tSQfWr6Z4h+jEvQgBiUsdbN+cx0pYnpOIEtd1bWnc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oYk6fwKqnH2Nk8sGJ6D8d64FLUuzVrjyWTNH93uoUU4x1wu3sdQB6doP00Mr1GF/3 hZI+lFusX6uB0+iqM7LzEHB5hCS2VWtEBl+Vm296yqq+oIE9ZMx4y0BSgVQo/MDmUG UemhXC3MrRn/5ccZxRyoPoo5GDz4DfXSTxnm7YbQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kangjie Lu Subject: [PATCH 4.19 078/134] tty: mxs-auart: fix a potential NULL pointer dereference Date: Mon, 1 Apr 2019 19:01:54 +0200 Message-Id: <20190401170051.688270055@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170044.243719205@linuxfoundation.org> References: <20190401170044.243719205@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kangjie Lu commit 6734330654dac550f12e932996b868c6d0dcb421 upstream. In case ioremap fails, the fix returns -ENOMEM to avoid NULL pointer dereferences. Multiple places use port.membase. Signed-off-by: Kangjie Lu Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/mxs-auart.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/tty/serial/mxs-auart.c +++ b/drivers/tty/serial/mxs-auart.c @@ -1685,6 +1685,10 @@ static int mxs_auart_probe(struct platfo s->port.mapbase = r->start; s->port.membase = ioremap(r->start, resource_size(r)); + if (!s->port.membase) { + ret = -ENOMEM; + goto out_disable_clks; + } s->port.ops = &mxs_auart_ops; s->port.iotype = UPIO_MEM; s->port.fifosize = MXS_AUART_FIFO_SIZE;