From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EECAFC10F05 for ; Mon, 1 Apr 2019 18:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6AB220880 for ; Mon, 1 Apr 2019 18:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554141633; bh=EF8KO8s/qyYORiYqmU3kDcNSIk0hlTDVSNXqAwm/a04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZW+CoQtEdVZVy5949902xwyw76A3gBil9qkjXlhNNTnan8wAE7DsvmFrwCMy/5Icw tmyDyoXxw3fagLlIyNNMyAzsT5W8Ezrmor/bZrupPrFImPj13bf5OMnl+R8d7Julky CNh3fm94qqxTU5m8LYzukO7mEql1FdZsbDks/KKg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730819AbfDARRX (ORCPT ); Mon, 1 Apr 2019 13:17:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:43456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730541AbfDARRW (ORCPT ); Mon, 1 Apr 2019 13:17:22 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F53D21473; Mon, 1 Apr 2019 17:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1554139041; bh=EF8KO8s/qyYORiYqmU3kDcNSIk0hlTDVSNXqAwm/a04=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PAx3Xj9VW+uTMCQJcfbwDbc/a20e97Lb2NXcl2lMwJdnL0pXX6pm+1+rG9HHHuqVB s3Aw7ahv//tJ6iW6KS7R8NstnNFbSltJH7Qu1GeryFoq0XqdfpP//vl25aaJYnCfYv 69g3fAupKxE0PsG8c/l4pW4XZ45LfFftKONrVm6s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wentao Wang , Daniel Thompson Subject: [PATCH 4.19 095/134] Disable kgdboc failed by echo space to /sys/module/kgdboc/parameters/kgdboc Date: Mon, 1 Apr 2019 19:02:11 +0200 Message-Id: <20190401170053.130214866@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190401170044.243719205@linuxfoundation.org> References: <20190401170044.243719205@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wentao Wang commit 3ec8002951ea173e24b466df1ea98c56b7920e63 upstream. Echo "" to /sys/module/kgdboc/parameters/kgdboc will fail with "No such device” error. This is caused by function "configure_kgdboc" who init err to ENODEV when the config is empty (legal input) the code go out with ENODEV returned. Fixes: 2dd453168643 ("kgdboc: Fix restrict error") Signed-off-by: Wentao Wang Cc: stable Acked-by: Daniel Thompson Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/kgdboc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/tty/serial/kgdboc.c +++ b/drivers/tty/serial/kgdboc.c @@ -145,8 +145,10 @@ static int configure_kgdboc(void) char *cptr = config; struct console *cons; - if (!strlen(config) || isspace(config[0])) + if (!strlen(config) || isspace(config[0])) { + err = 0; goto noconfig; + } kgdboc_io_ops.is_console = 0; kgdb_tty_driver = NULL;